Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency binaries #63

Merged
merged 14 commits into from
Aug 17, 2022
Merged

Remove dependency binaries #63

merged 14 commits into from
Aug 17, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Aug 17, 2022 •
edited
Loading

@vaind vaind force-pushed the ci/deps branch 2 times, most recently from f9ccd2f to c74afb7 Compare August 17, 2022 10:02
@vaind vaind force-pushed the ci/deps branch 2 times, most recently from ceb641c to b6069ad Compare August 17, 2022 10:49
@vaind vaind mentioned this pull request Aug 17, 2022
Closed
5 tasks
@vaind vaind marked this pull request as ready for review August 17, 2022 13:01
@vaind vaind requested a review from tustanivsky August 17, 2022 13:01
@tustanivsky
Copy link
Collaborator

We should call scripts/download-sdks.sh on the client in order to download the latest dependencies, right? If so, probably some kind of pre-processing in the plugin to trigger that (i.e. PreBuildSteps in Sentry.uplugin file) will be required. Ofc calling it manually is an option as well

@vaind
Copy link
Collaborator Author

vaind commented Aug 17, 2022

We should call scripts/download-sdks.sh on the client in order to download the latest dependencies, right? If so, probably some kind of pre-processing in the plugin to trigger that (i.e. PreBuildSteps in Sentry.uplugin file) will be required. Ofc calling it manually is an option as well

I wouldn't add it as a pre-processing because it's only for sentry-unreal developers, not plugin end-users

tustanivsky
tustanivsky approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@tustanivsky tustanivsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@vaind vaind merged commit 665c792 into main Aug 17, 2022
@vaind vaind deleted the ci/deps branch August 17, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustanivsky tustanivsky tustanivsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor build scripts for plugin dependencies Avoid precompiled binaries in the repo
2 participants
@vaind @tustanivsky