Add trace propagation #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add trace propagation ([#631](https://github.com/getsentry/sentry-unreal/pull/631))If none of the above apply, you can opt out of this check by adding |
plugin-dev/Source/Sentry/Private/Android/Infrastructure/SentryJavaClasses.cpp
Show resolved
Hide resolved
| @@ -303,3 +302,36 @@ USentryTransaction* SentrySubsystemApple::StartTransactionWithContextAndOptions( | |||
|
|
|||
| return SentryConvertorsApple::SentryTransactionToUnreal(transaction); | |||
| } | |||
|
|
|||
| USentryTransactionContext* SentrySubsystemApple::ContinueTrace(const FString& sentryTrace, const TArray<FString>& baggageHeaders) | |||
There was a problem hiding this comment.
Can we add some tests for this?
There was a problem hiding this comment.
Yeah, I've added a basic one. The existing sentry-native API is quite limited though so it's somewhat problematic to set up thorough testing for the tracing feature.
Co-authored-by: Stefan Jandl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing APIs required for the distributed tracing feature. Basically, now it's possible to create a new
TransactionContextbased on a given trace header and query existing span/transaction trace info for its further propagation.Closes #627