-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(replay): Allow replay player instances to be interactable/scrolla…
…ble again (#77647) Broke in https://github.com/getsentry/sentry/pull/76927/files#diff-e10692ee093e56669e267837b07b16ed1d800a6dc996049aea27186f5fe0b8bbR21 because that code is used by: https://github.com/getsentry/sentry/blame/21e8cd7/static/app/components/replays/replayPlayer.tsx#L185-L193 Fixes #77608 (comment) 1. What I've done is make all the replay views "inspectable" by allowing pointer-events. So links can be clicked inside the replay... but also doing "Right-Click -> Inspect Element" works great again. 2. The attribute `scrolling="no"` is set, and from what I can tell was always set on the iframe. So i'm not sure how or when that behavior changed.
- Loading branch information
Showing
3 changed files
with
3 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters