Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replays Are No Longer Scrollable #77608

Closed
ReneGreen27 opened this issue Sep 16, 2024 · 6 comments · Fixed by #77647
Closed

Replays Are No Longer Scrollable #77608

ReneGreen27 opened this issue Sep 16, 2024 · 6 comments · Fixed by #77647
Assignees

Comments

@ReneGreen27
Copy link
Member

Problem Statement

Previously when navigating to an individual Replay screen and pressing play, you could mouse over the replay videos and scroll up and down the page as if you are the user.

Now when attempting to do this the browser page moves, not the replay video, you can reference internal ticket #132252 for a video reproduction.

I was able to reproduce this behavior in latest version of Chrome and Firefox, video reproduction demonstrates this occurring in Edge.

Solution Brainstorm

Customer would like for this feature to be restored as this was very helpful for them in debugging with replays.

Product Area

Replays

@getsantry
Copy link
Contributor

getsantry bot commented Sep 16, 2024

Routing to @getsentry/product-owners-replays for triage ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Sep 16, 2024

Auto-routing to @getsentry/product-owners-replays for triage ⏲️

@bruno-garcia
Copy link
Member

bruno-garcia commented Sep 17, 2024

I'm not sure what scrollable experience they meant, we didn't reallly change anything in that regard.
Our aim is to have a reproduction of the site/user session so if the user scrolls on a page, the replay should reflect that. So the replay shows what the user saw already.

See @billyvg 's message below

@billyvg
Copy link
Member

billyvg commented Sep 17, 2024

rrweb by default has a css property on the iframe to ignore all mouse events inside of it. However, we wanted to let users be able to inspect elements within their replay (i.e. inside of the iframe), so we disabled this CSS property. A consequence of that is that users are able to interact with the replay in any way they wish (including scrolling).

This regressed, but we're fixing it.

ryan953 added a commit that referenced this issue Sep 17, 2024
…ble again (#77647)

Broke in
https://github.com/getsentry/sentry/pull/76927/files#diff-e10692ee093e56669e267837b07b16ed1d800a6dc996049aea27186f5fe0b8bbR21
because that code is used by:
https://github.com/getsentry/sentry/blame/21e8cd7/static/app/components/replays/replayPlayer.tsx#L185-L193

Fixes #77608 (comment)


1. What I've done is make all the replay views "inspectable" by allowing
pointer-events. So links can be clicked inside the replay... but also
doing "Right-Click -> Inspect Element" works great again.

2. The attribute `scrolling="no"` is set, and from what I can tell was
always set on the iframe. So i'm not sure how or when that behavior
changed.
@ryan953
Copy link
Member

ryan953 commented Sep 17, 2024

What I've done is make all the replay views "inspectable" by allowing pointer-events as @billyvg described. So links can be clicked inside the replay... but also doing "Right-Click -> Inspect Element" works great again.

The attribute scrolling="no" is set on the iframe though, and as far as i can tell I don't know how it could've become unset at any point. So i'm not sure how or when that behavior changed. Currently in my testing scrolling is not possible, but Right-click To Inspect is working better now (as the deploy finishes up)

@billyvg
Copy link
Member

billyvg commented Sep 18, 2024

I think with scrolling="no", scrolling is still possible as long as it's not the iframe scrolling (e.g. you have child divs that have overflow, those should still scroll).

harshithadurai pushed a commit that referenced this issue Sep 19, 2024
…ble again (#77647)

Broke in
https://github.com/getsentry/sentry/pull/76927/files#diff-e10692ee093e56669e267837b07b16ed1d800a6dc996049aea27186f5fe0b8bbR21
because that code is used by:
https://github.com/getsentry/sentry/blame/21e8cd7/static/app/components/replays/replayPlayer.tsx#L185-L193

Fixes #77608 (comment)


1. What I've done is make all the replay views "inspectable" by allowing
pointer-events. So links can be clicked inside the replay... but also
doing "Right-Click -> Inspect Element" works great again.

2. The attribute `scrolling="no"` is set, and from what I can tell was
always set on the iframe. So i'm not sure how or when that behavior
changed.
harshithadurai pushed a commit that referenced this issue Sep 19, 2024
…ble again (#77647)

Broke in
https://github.com/getsentry/sentry/pull/76927/files#diff-e10692ee093e56669e267837b07b16ed1d800a6dc996049aea27186f5fe0b8bbR21
because that code is used by:
https://github.com/getsentry/sentry/blame/21e8cd7/static/app/components/replays/replayPlayer.tsx#L185-L193

Fixes #77608 (comment)


1. What I've done is make all the replay views "inspectable" by allowing
pointer-events. So links can be clicked inside the replay... but also
doing "Right-Click -> Inspect Element" works great again.

2. The attribute `scrolling="no"` is set, and from what I can tell was
always set on the iframe. So i'm not sure how or when that behavior
changed.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants