-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replays Are No Longer Scrollable #77608
Comments
Routing to @getsentry/product-owners-replays for triage ⏲️ |
Auto-routing to @getsentry/product-owners-replays for triage ⏲️ |
See @billyvg 's message below |
rrweb by default has a css property on the iframe to ignore all mouse events inside of it. However, we wanted to let users be able to inspect elements within their replay (i.e. inside of the iframe), so we disabled this CSS property. A consequence of that is that users are able to interact with the replay in any way they wish (including scrolling). This regressed, but we're fixing it. |
…ble again (#77647) Broke in https://github.com/getsentry/sentry/pull/76927/files#diff-e10692ee093e56669e267837b07b16ed1d800a6dc996049aea27186f5fe0b8bbR21 because that code is used by: https://github.com/getsentry/sentry/blame/21e8cd7/static/app/components/replays/replayPlayer.tsx#L185-L193 Fixes #77608 (comment) 1. What I've done is make all the replay views "inspectable" by allowing pointer-events. So links can be clicked inside the replay... but also doing "Right-Click -> Inspect Element" works great again. 2. The attribute `scrolling="no"` is set, and from what I can tell was always set on the iframe. So i'm not sure how or when that behavior changed.
What I've done is make all the replay views "inspectable" by allowing pointer-events as @billyvg described. So links can be clicked inside the replay... but also doing "Right-Click -> Inspect Element" works great again. The attribute scrolling="no" is set on the iframe though, and as far as i can tell I don't know how it could've become unset at any point. So i'm not sure how or when that behavior changed. Currently in my testing scrolling is not possible, but Right-click To Inspect is working better now (as the deploy finishes up) |
I think with |
…ble again (#77647) Broke in https://github.com/getsentry/sentry/pull/76927/files#diff-e10692ee093e56669e267837b07b16ed1d800a6dc996049aea27186f5fe0b8bbR21 because that code is used by: https://github.com/getsentry/sentry/blame/21e8cd7/static/app/components/replays/replayPlayer.tsx#L185-L193 Fixes #77608 (comment) 1. What I've done is make all the replay views "inspectable" by allowing pointer-events. So links can be clicked inside the replay... but also doing "Right-Click -> Inspect Element" works great again. 2. The attribute `scrolling="no"` is set, and from what I can tell was always set on the iframe. So i'm not sure how or when that behavior changed.
…ble again (#77647) Broke in https://github.com/getsentry/sentry/pull/76927/files#diff-e10692ee093e56669e267837b07b16ed1d800a6dc996049aea27186f5fe0b8bbR21 because that code is used by: https://github.com/getsentry/sentry/blame/21e8cd7/static/app/components/replays/replayPlayer.tsx#L185-L193 Fixes #77608 (comment) 1. What I've done is make all the replay views "inspectable" by allowing pointer-events. So links can be clicked inside the replay... but also doing "Right-Click -> Inspect Element" works great again. 2. The attribute `scrolling="no"` is set, and from what I can tell was always set on the iframe. So i'm not sure how or when that behavior changed.
Problem Statement
Previously when navigating to an individual Replay screen and pressing play, you could mouse over the replay videos and scroll up and down the page as if you are the user.
Now when attempting to do this the browser page moves, not the replay video, you can reference internal ticket #132252 for a video reproduction.
I was able to reproduce this behavior in latest version of Chrome and Firefox, video reproduction demonstrates this occurring in Edge.
Solution Brainstorm
Customer would like for this feature to be restored as this was very helpful for them in debugging with replays.
Product Area
Replays
The text was updated successfully, but these errors were encountered: