[Replay Details - Bug] If seeking before play is pressed, wrong video is shown at first #67847
Comments
michellewzhang
changed the title
michellewzhang
added a commit
that referenced
this issue
Mar 28, 2024
Fixes #67847 Calling `loadSegment(0)` in the constructor works under the assumption that we'll always play the replay from the beginning; however, there's a case where the user might seek to a later part of the video before pressing play first. This was resulting in a bug where the first video was always playing even though that wasn't the right part of the video. We don't actually need to the `loadSegment(0)` call at all for the replay to play normally from the beginning (see last video): ## BEFORE: Replay was playing first clip erroneously after seeking to later part of the video https://github.com/getsentry/sentry/assets/56095982/4fc77cff-ab30-4026-8e14-28764c1dda50 ## AFTER: Replay plays correctly if we seek to later part of the video https://github.com/getsentry/sentry/assets/56095982/ae8e77f8-f918-45bd-a577-300a9bf96254 ## Replay plays normally from beginning https://github.com/getsentry/sentry/assets/56095982/e76b3694-f33a-4aa5-9681-ab820e439eb9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Screen.Recording.2024-03-27.at.10.23.48.PM.mov
If you seek to a later point in the video without pressing play first, the wrong clip is shown for a couple seconds before the correct one resumes.
The text was updated successfully, but these errors were encountered: