Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replays): don't load segment 0 #67911

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix(replays): don't load segment 0 #67911

merged 2 commits into from
Mar 28, 2024

Conversation

michellewzhang
Copy link
Member

Fixes #67847

Calling loadSegment(0) in the constructor works under the assumption that we'll always play the replay from the beginning; however, there's a case where the user might seek to a later part of the video before pressing play first. This was resulting in a bug where the first video was always playing even though that wasn't the right part of the video. We don't actually need to the loadSegment(0) call at all for the replay to play normally from the beginning (see last video):

BEFORE: Replay was playing first clip erroneously after seeking to later part of the video

Screen.Recording.2024-03-27.at.10.23.48.PM.mov

AFTER: Replay plays correctly if we seek to later part of the video

Screen.Recording.2024-03-28.at.2.09.54.PM.mov

Replay plays normally from beginning

Screen.Recording.2024-03-28.at.2.12.15.PM.mov

@michellewzhang michellewzhang requested a review from a team as a code owner March 28, 2024 21:14
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 28, 2024
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Though I think we will want to have the first frame of the video displayed instead of an empty panel

@michellewzhang
Copy link
Member Author

👍 Though I think we will want to have the first frame of the video displayed instead of an empty panel

yup, not sure why it isn't always showing but i'll look into it!

@michellewzhang michellewzhang merged commit 21ffe45 into master Mar 28, 2024
42 checks passed
@michellewzhang michellewzhang deleted the mz/nopreloadseg branch March 28, 2024 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Replay Details - Bug] If seeking before play is pressed, wrong video is shown at first
2 participants