Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replays): don't load segment 0 #67911

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix(replays): don't load segment 0 #67911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f36374
fix(replays): don't load segment 0
michellewzhang Mar 28, 2024
4ef0454
undefined
michellewzhang Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion static/app/components/replays/videoReplayer.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ describe('VideoReplayer - no starting gap', () => {
onLoaded: jest.fn(),
});
// @ts-expect-error private
expect(inst._currentIndex).toEqual(0);
// currentIndex is undefined before we ever press play
expect(inst._currentIndex).toEqual(undefined);

const playPromise = inst.play(6500);
jest.advanceTimersByTime(10000);
Expand Down
1 change: 0 additions & 1 deletion static/app/components/replays/videoReplayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ export class VideoReplayer {
this.preloadVideos({low: 0, high: PRELOAD_BUFFER});

this._trackList = this._attachments.map(({timestamp}, i) => [timestamp, i]);
this.loadSegment(0);
}

private createVideo(segmentData: VideoEvent, index: number) {
Expand Down
Loading