Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sentry_apps): Move logic and refs to use new tasks, round 2 #78794

Merged
merged 16 commits into from
Oct 9, 2024

Conversation

Christinarlong
Copy link
Contributor

@Christinarlong Christinarlong commented Oct 8, 2024

old one: (#78347) -> was reverted due to shim erroring tasks

Have the new tasks contain the logic and point other refs torward the new tasks.

issue ref (#73857 )

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 84.88372% with 39 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/sentry_apps/tasks/sentry_apps.py 86.13% 20 Missing and 8 partials ⚠️
src/sentry/tasks/sentry_apps.py 61.90% 8 Missing ⚠️
src/sentry/sentry_apps/tasks/service_hooks.py 92.00% 2 Missing ⚠️
src/sentry/tasks/servicehooks.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #78794      +/-   ##
==========================================
- Coverage   78.22%   78.17%   -0.06%     
==========================================
  Files        7105     7089      -16     
  Lines      313140   312581     -559     
  Branches    51129    51090      -39     
==========================================
- Hits       244965   244349     -616     
- Misses      61811    61860      +49     
- Partials     6364     6372       +8     

@Christinarlong Christinarlong marked this pull request as ready for review October 8, 2024 21:40
@Christinarlong Christinarlong requested review from a team as code owners October 8, 2024 21:40
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Christinarlong Christinarlong merged commit ba002f8 into master Oct 9, 2024
52 of 53 checks passed
@Christinarlong Christinarlong deleted the move-logic-to-new-sa-tasks branch October 9, 2024 15:46
Copy link

sentry-io bot commented Oct 10, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SnubaError: HTTPConnectionPool(host='127.0.0.1', port=1218): Max retries exceeded with url: /events/snql (Cau... pytest.runtest.protocol tests/sentry/sentry_app... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants