Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Modules - Consolidate SentryApps resources #73857

Open
markstory opened this issue Jul 4, 2024 · 0 comments
Open

App Modules - Consolidate SentryApps resources #73857

markstory opened this issue Jul 4, 2024 · 0 comments

Comments

@markstory
Copy link
Member

SentryApps and its direct relations are control_silo scoped resources. Currently the components that comprise the control silo aspects of sentryapps are spread throughout the repository. Consolidating those classes and functions into sentry.sentry_apps will help clarify the application's design and make running subsets of tests easier and faster.

  • Replace usage of Mediator with dataclasses that implement the same approximate API as the mediators do today. Mediators duplicate the role of serializers and don't have enough adoption to justify continued inclusion in the repository.
  • Move endpoints, serializers, models, and tasks to be co-located.

We'll need to provide import shims for any symbols used in getsentry until those imports can be updated separately.

cc @Christinarlong
This was referenced Sep 13, 2024
Merged
Merged
Christinarlong added a commit that referenced this issue Sep 17, 2024
@Christinarlong @getsantry
ref(sentry_apps): Rename apps.py and shim for getsentry (#77614)
825d60c 
We need to rename `apps.py` so django doesn't confuse it for an
`AppConfig` file when we later add `sentry_apps` to `INSTALLED APPS.`
However, `apps.py` is also used in `getsentry` so we'll need to create a
shim so that refs don't break.

ref(#73857)

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Christinarlong added a commit that referenced this issue Sep 18, 2024
@Christinarlong
ref(sentry_apps): move sentryapp model to sentry_apps dir (#77521)
a4c01fe 
issue ref(#73857)
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
harshithadurai pushed a commit that referenced this issue Sep 19, 2024
@Christinarlong
ref(sentry_apps): move sentryapp model to sentry_apps dir (#77521)
4abba45 
issue ref(#73857)
Christinarlong added a commit that referenced this issue Sep 19, 2024
@Christinarlong
ref(sentry_apps): Move SentryAppInstallationToken to sentry_apps (#77734
7f64faa 
)

issue ref(#73857)
harshithadurai pushed a commit that referenced this issue Sep 19, 2024
@Christinarlong
ref(sentry_apps): move sentryapp model to sentry_apps dir (#77521)
be7b3ce 
issue ref(#73857)
harshithadurai pushed a commit that referenced this issue Sep 19, 2024
@Christinarlong
ref(sentry_apps): Move SentryAppInstallationToken to sentry_apps (#77734
1f5e072 
)

issue ref(#73857)
Christinarlong added a commit that referenced this issue Sep 19, 2024
@Christinarlong
chore(sentry_app): Move SentryAppComponent to sentry_apps (#77752)
e6c247a 
migrate SentryAppComponent model to sentry_apps!
[X] model
[] tests - N/A
[] typing - N/A
[] getsentry shim - N/A

issue ref(#73857)
Christinarlong added a commit that referenced this issue Sep 20, 2024
@Christinarlong
chore(sentry_apps): Move SentryAppInstallationForProvider to sentry_a…
460232f 
…pps (#77738)

migrate SentryAppInstallationForProvider to sentry_apps!
[X] model
[] tests - N/A
[] typing - N/A
[] getsentry shim - N/A

issue ref(#73857)
Christinarlong added a commit that referenced this issue Sep 20, 2024
@Christinarlong
chore(sentry_apps): move servicehook model to sentry_apps (#77760)
378e765 
migrate ServiceHook model to sentry_apps!
[X] model
[] tests - N/A
[] typing - N/A
[] getsentry shim - N/A

issue ref(#73857)
This was referenced Sep 20, 2024
Merged
Merged
Merged
Christinarlong added a commit that referenced this issue Sep 23, 2024
@Christinarlong @getsantry @markstory
chore(sentry_apps): Move over misc sentry app endpoints to sentry_apps (
0f77e5a 
#77887)

Move the endpoints that weren't in a subdirectory to sentry_apps!
[X] endpoints
[X] tests
[x] typing - turns out we do take in an RpcUser in various places when
creating/updating sentry apps
[] getsentry shim - N/A

issue ref(#73857)

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Co-authored-by: Mark Story <[email protected]>
@Christinarlong Christinarlong mentioned this issue Sep 23, 2024
Merged
harshithadurai pushed a commit that referenced this issue Sep 24, 2024
@Christinarlong @getsantry @markstory
chore(sentry_apps): Move over misc sentry app endpoints to sentry_apps (
6a41a57 
#77887)

Move the endpoints that weren't in a subdirectory to sentry_apps!
[X] endpoints
[X] tests
[x] typing - turns out we do take in an RpcUser in various places when
creating/updating sentry apps
[] getsentry shim - N/A

issue ref(#73857)

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Co-authored-by: Mark Story <[email protected]>
This was referenced Sep 24, 2024
Merged
Merged
0Calories pushed a commit that referenced this issue Sep 25, 2024
@Christinarlong @getsantry
@markstory @0Calories
chore(sentry_apps): Move over misc sentry app endpoints to sentry_apps (
8fec0c0 
#77887)

Move the endpoints that weren't in a subdirectory to sentry_apps!
[X] endpoints
[X] tests
[x] typing - turns out we do take in an RpcUser in various places when
creating/updating sentry apps
[] getsentry shim - N/A

issue ref(#73857)

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Co-authored-by: Mark Story <[email protected]>
This was referenced Sep 27, 2024
Merged
Merged
Merged
Merged
Merged
@Christinarlong Christinarlong mentioned this issue Oct 5, 2024
Merged
Christinarlong added a commit that referenced this issue Oct 7, 2024
@Christinarlong @markstory
chore(sentry apps): Move logic to new Sentry App tasks (#78347)
3016618 
Have the new tasks contain the logic and point other refs torward the
new tasks.

issue ref (#73857 )

---------

Co-authored-by: Mark Story <[email protected]>
This was referenced Oct 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 17, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markstory