Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail processing minidumps on invalid code_file #1133

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Do not fail processing minidumps on invalid code_file #1133

merged 2 commits into from
Apr 7, 2023

Commits on Apr 7, 2023

  1. Do not fail processing minidumps on invalid code_file. 

    Invalid base-names will be excluded from symbol server lookups, which will certainly not find anything useful. We still output the full (invalid) code file into the symbolicated event, as it might still be useful to customers.

As a drive-by change, this reverts the `capture_anyhow` change that captures real stack traces in S4S, as the stack traces are not that useful, and the grouping is worse.
    @Swatinem
    Swatinem committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    5cd3bb6 View commit details
    Browse the repository at this point in the history

  2. comment

    @Swatinem
    Swatinem committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    2d53bec View commit details
    Browse the repository at this point in the history