ref(symbolication): Preserve and propagate errors better #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error reporting here was all truncated to "cancelled" or "timeout" with no extra information, resulting in opaque errors like "internal errror" with no other information. This changes a number of functions over to anyhow::Error with cause chainging. Only top-level timeouts are still propagated as SymbolicationError::Timeout with some inner onces being mapped to anyhow::Error, which now maps into SymbolicationError::Canceled. Error reporting in the request future now also logs the error instead of only capturing it in Sentry. This allows also getting the errors during test runs and other debugging.
Swatinem
approved these changes
Jan 25, 2021
jan-auer
reviewed
Jan 26, 2021
added 3 commits
January 26, 2021 09:21
This only wraps inner errors.
This was only saved for things which aren't a timeout. Let's not change this now.
jan-auer
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error reporting here was all truncated to "cancelled" or "timeout"
with no extra information, resulting in opaque errors like "internal
errror" with no other information. This changes a number of functions
over to anyhow::Error with cause chainging. Only top-level timeouts
are still propagated as SymbolicationError::Timeout with some inner
onces being mapped to anyhow::Error, which now maps into
SymbolicationError::Canceled.
Error reporting in the request future now also logs the error instead
of only capturing it in Sentry. This allows also getting the errors
during test runs and other debugging.
#skip-changelog