Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(symbolication): Preserve and propagate errors better #365

Merged
merged 4 commits into from
Jan 26, 2021

Commits on Jan 25, 2021

  1. ref(symbolication): Preserve and propagate errors better

    The error reporting here was all truncated to "cancelled" or "timeout"
    with no extra information, resulting in opaque errors like "internal
    errror" with no other information.  This changes a number of functions
    over to anyhow::Error with cause chainging.  Only top-level timeouts
    are still propagated as SymbolicationError::Timeout with some inner
    onces being mapped to anyhow::Error, which now maps into
    SymbolicationError::Canceled.
    
    Error reporting in the request future now also logs the error instead
    of only capturing it in Sentry.  This allows also getting the errors
    during test runs and other debugging.
    Floris Bruynooghe committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    cc15fbe View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Rename the main error and mark it transparent

    This only wraps inner errors.
    Floris Bruynooghe committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    92e0d2c View commit details
    Browse the repository at this point in the history
  2. Better variable naming

    Floris Bruynooghe committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    73cee32 View commit details
    Browse the repository at this point in the history
  3. Do not change behaviour of when to save the minidump

    This was only saved for things which aren't a timeout.  Let's not
    change this now.
    Floris Bruynooghe committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    943dde4 View commit details
    Browse the repository at this point in the history