Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(services): Move actors into services #377

Merged
merged 2 commits into from
Feb 6, 2021
Merged

ref(services): Move actors into services #377

merged 2 commits into from
Feb 6, 2021

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Feb 6, 2021 •
edited
Loading

Moves all services from the actors module into services. For a very long
time, none of these have been actors.

Additionally, app::ServiceState has been moved to services::Service to
reflect its true meaning. The entire service layer is now free of references to
actix, while endpoints continue to use the Service as state.

#skip-changelog

@jan-auer jan-auer requested a review from a team February 6, 2021 16:44
@jan-auer jan-auer mentioned this pull request Feb 6, 2021
Merged
@jan-auer jan-auer self-assigned this Feb 6, 2021
@jan-auer jan-auer merged commit 9c7e338 into master Feb 6, 2021
@jan-auer jan-auer deleted the ref/actors-services branch February 6, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @Swatinem