ref(service): Remove unused I/O threadpool #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is based on #377. |
jan-auer
force-pushed
the
ref/remove-unused-io-pool
branch
from
728e97b
to
7d112b3
Compare
Swatinem
approved these changes
Feb 6, 2021
jan-auer
force-pushed
the
ref/remove-unused-io-pool
branch
from
7d112b3
to
1ac7561
Compare
|
That's an excellent question, I'm not entirely sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service state used to create an I/O threadpool that was passed into the
objects and download services. The pool has been removed from the Download
service since, and is not used in the objects actor. Therefore, it is dead code
and can be removed.
#skip-changelog