Track depth and stencil writability separately. #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
type: enhancement
|
|
jimblandy
force-pushed
the
separate-depth-stencil-read-only
branch
from
995eadc
to
eb1d484
Compare
cwfitzgerald
requested changes
Jun 4, 2022
jimblandy
force-pushed
the
separate-depth-stencil-read-only
branch
from
eb1d484
to
40e7144
Compare
Put some plumbing in place to accomodate the latest definition of `GPURenderBundleEncoderDescriptor` in the WebGPU spec, which now has separate `depthReadOnly` and `stencilReadOnly` members. Rename `RenderPassDepthStencilAttachment::is_read_only` to `depth_stencil_read_only`, and don't skip validation steps due to early returns.
jimblandy
force-pushed
the
separate-depth-stencil-read-only
branch
from
40e7144
to
11c0494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put some plumbing in place to accomodate the latest definition of
GPURenderBundleEncoderDescriptorin the WebGPU spec, which now has separatedepthReadOnlyandstencilReadOnlymembers.Rename
RenderPassDepthStencilAttachment::is_read_onlytodepth_stencil_read_only, and don't skip validation steps due to early returns.