-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Ember Octane / 4.x support #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated to current dependencies - Removed bower - Tests still don't work 😢
Force subscribe to the channel in the rewire method
gilgen
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks @gorner!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates are necessary to ensure compatibility with Ember Octane / 4.x. The main concern is updating ember-cli-babel to v7.26.11 since earlier versions of that lib referenced the Ember global and cause warnings to be thrown in any Ember 3.28+ app using it.
Note that while my working assumption is that this update should target master, the more useful diff here is likely 2.0.0-beta.1...gorner:octanify since I built off the https://github.com/gilgen/ember-pusher/tree/2.0.0-beta.1 branch, and the current master branch is actually v1.1.1. If you'd prefer that I create a v3 branch instead, let me know.
What else I've done:
However I haven't made any other significant changes to the add-on's structure or APIs.
If you have any other questions about this PR, you know where to find me 😉