Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Ember Octane / 4.x support #49

Merged
merged 14 commits into from
Jul 6, 2023
Merged

Conversation

gorner
Copy link
Contributor

@gorner gorner commented Jul 6, 2023

These updates are necessary to ensure compatibility with Ember Octane / 4.x. The main concern is updating ember-cli-babel to v7.26.11 since earlier versions of that lib referenced the Ember global and cause warnings to be thrown in any Ember 3.28+ app using it.

Note that while my working assumption is that this update should target master, the more useful diff here is likely 2.0.0-beta.1...gorner:octanify since I built off the https://github.com/gilgen/ember-pusher/tree/2.0.0-beta.1 branch, and the current master branch is actually v1.1.1. If you'd prefer that I create a v3 branch instead, let me know.

What else I've done:

  • Updated the ember-cli blueprint to 3.28 - this includes a number of dependency updates and drops support for versions of Node before 12 (current Node LTS is v18)
  • Updated code to explicitly inject the pusher service where necessary due to the removal of implicit injection support in 4.x (though leaving the initializer itself appears to be OK for now)
  • Fixed a couple of other issues raised by the linter. In attempting to apply automated fixes for some of these, I ended up applying some code style updates from Prettier (included in the updated blueprint), I can revert these if you feel strongly about them.
  • Moved the pusher-js package to a peer dependency - there've been several recent major-version bumps to pusher-js that don't impact ember-pusher so I don't think they need to be tightly coupled

However I haven't made any other significant changes to the add-on's structure or APIs.

If you have any other questions about this PR, you know where to find me 😉

Copy link
Owner

@gilgen gilgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @gorner!

@gilgen gilgen merged commit 1e52642 into gilgen:master Jul 6, 2023
@gorner gorner deleted the octanify branch September 11, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants