Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove injections initializer #50

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gorner
Copy link
Contributor

@gorner gorner commented Apr 18, 2024

One of the changes in PR #49 was (emphasis added):

  • Updated code to explicitly inject the pusher service where necessary due to the removal of implicit injection support in 4.x (though leaving the initializer itself appears to be OK for now)

However, on Ember 4, such injection initializers raise a deprecation warning, and on Ember 5, they result in the error TypeError: application.inject is not a function which will prevent the app from running. As such, the injection initializer must be completely removed in order for ember-pusher to work on Ember 5.

This is a potentially breaking change for any users of this addon on Ember versions prior to 4.x that have not already resolved the 3.x implicit-injections deprecation introduced in Ember 3.26 (which warned app developers to add explicit injections for any services they used). However, as the only release of ember-pusher 3.x so far has been an alpha release, I don't believe a further major version bump is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant