Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the changes in PR #49 was (emphasis added):
However, on Ember 4, such injection initializers raise a deprecation warning, and on Ember 5, they result in the error
TypeError: application.inject is not a function
which will prevent the app from running. As such, the injection initializer must be completely removed in order for ember-pusher to work on Ember 5.This is a potentially breaking change for any users of this addon on Ember versions prior to 4.x that have not already resolved the 3.x
implicit-injections
deprecation introduced in Ember 3.26 (which warned app developers to add explicit injections for any services they used). However, as the only release of ember-pusher 3.x so far has been an alpha release, I don't believe a further major version bump is required.