Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RECHERCHE] suggerer de poser la question si les résultats ne conviennent pas #504

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

vincentporte
Copy link
Contributor

@vincentporte vincentporte commented Jan 18, 2024

Description

🎸 Ajouter le bouton "poser la question" sur la page de résultat
🎸 Suppression du formulaire embarqué Tally en bas de page
🎸 Correction de l'espacement entre les radiobutton du formulaire

🦺 Ajout de forum en contexte de la vue FacetedSearchView pour hydrater le retournement de l'hyperlien topic:create
🦺 Ajout de 2 snapshots dans test_search_indexes.test_extra_context : formulaire avant recherche, recherche sans résultat.
🦺 Installation de beautifulsoup4, sirupy et html5lib pour gérer les snapshots et parser le contenu html de la balise main
🦺 AJout de la méthode parse_response_to_soup et de son test : reprise des emplois, PR#3525

Type de changement

🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).

Captures d'écran

Positionnement des radiobuttons

image

Version sans résultat

image

Version avec résultat

image

@vincentporte vincentporte self-assigned this Jan 18, 2024
@vincentporte vincentporte linked an issue Jan 18, 2024 that may be closed by this pull request
3 tasks
@vincentporte vincentporte force-pushed the 501-recherche-stats-des-requetes-perdues branch from 5a74380 to 67b8abf Compare January 18, 2024 16:30
@vincentporte vincentporte marked this pull request as ready for review January 18, 2024 16:33
@vincentporte vincentporte added the python Pull requests that update Python code label Jan 18, 2024
Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autrement, ça m’a l’air bien :)

lacommunaute/forum_search/tests/test_search_indexes.py Outdated Show resolved Hide resolved
Copy link
Contributor

@hellodeloo hellodeloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un petit commit pour :

  • un ajustement ui niveau alignement vertical
  • une petite correction semantique coté html
    Sinon, LGTM

@vincentporte vincentporte force-pushed the 501-recherche-stats-des-requetes-perdues branch from 3ca21ad to e7c5009 Compare January 23, 2024 13:35
@vincentporte vincentporte force-pushed the 501-recherche-stats-des-requetes-perdues branch 2 times, most recently from 6001dac to ea4915c Compare January 23, 2024 14:01
lacommunaute/forum_search/tests/test_search_indexes.py Outdated Show resolved Hide resolved

def extra_context(self):
extra = super().extra_context()
extra["forum"] = Forum.objects.filter(kind=ForumKind.PUBLIC_FORUM, lft=1, level=0).first()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heuu... Ça prend un forum public au pif ?

SELECT COUNT(*) FROM forum_forum WHERE lft=1 AND level=0 AND kind='PUBLIC_FORUM';
 count
-------
    10
(1 row)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non, ca prend le premier avec le level 0. Les forums et leur arborescence sont ordonnées dans l'admin via mptt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mais tu as peut-être des propositions pour identifier LE forum par défaut pour l'espace d'échanges ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Par son slug ?

@vincentporte vincentporte force-pushed the 501-recherche-stats-des-requetes-perdues branch from ea4915c to 9c76aad Compare January 23, 2024 15:21
@vincentporte vincentporte merged commit d65c2de into master Jan 23, 2024
4 checks passed
@vincentporte vincentporte deleted the 501-recherche-stats-des-requetes-perdues branch January 23, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RECHERCHE] stats des requetes perdues
3 participants