Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilitaires de test : gerer le remplacement des urls complexes #3525

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Utilitaires de test : gerer le remplacement des urls complexes #3525

merged 3 commits into from
Jan 11, 2024

Conversation

vincentporte
Copy link
Contributor

Pourquoi ?

Rendre parse_response_to_soup capable de gérer les urls complexes dans les snapshots.

ie : href="http://localhost:8000/company/job_description/[PK of JobDescription]/card?back_url=/company/[PK of Company]/card"

Comment ?

Modifier le traitement du paramètre replace_objects_pk_in_href :

  1. Si reçoit une liste de tuple, remplacement du premier membre du tuple par le second
  2. Sinon, maintien du fonctionnement existant, remplacement des PK de la liste d'objet de la liste

  • Ajouter l'étiquette « no-changelog » ?
  • Mettre à jour le CHANGELOG_breaking_changes.md ?

@vincentporte vincentporte self-assigned this Jan 11, 2024
@vincentporte vincentporte added the no-changelog Ne doit pas figurer dans le journal des changements. label Jan 11, 2024
@vincentporte vincentporte marked this pull request as ready for review January 11, 2024 10:56
xavfernandez
xavfernandez reviewed Jan 11, 2024
View reviewed changes
tests/utils/test.py Outdated Show resolved Hide resolved
@vincentporte vincentporte force-pushed the vincentporte/replace_objects_pk_in_href branch 2 times, most recently from ccff7e2 to cd34ee0 Compare January 11, 2024 13:40
xavfernandez
xavfernandez approved these changes Jan 11, 2024
View reviewed changes
tests/utils/test.py Outdated Show resolved Hide resolved
tests/www/companies_views/test_views.py Show resolved Hide resolved
@vincentporte vincentporte force-pushed the vincentporte/replace_objects_pk_in_href branch from cd34ee0 to eb89dc6 Compare January 11, 2024 15:39
@vincentporte vincentporte force-pushed the vincentporte/replace_objects_pk_in_href branch from eb89dc6 to 93e77d7 Compare January 11, 2024 16:04
@vincentporte vincentporte added this pull request to the merge queue Jan 11, 2024
Merged via the queue into master with commit eaa6e31 Jan 11, 2024
8 checks passed
@vincentporte vincentporte deleted the vincentporte/replace_objects_pk_in_href branch January 11, 2024 16:52
@vincentporte vincentporte mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees

@vincentporte vincentporte

Labels
no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentporte @xavfernandez