Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.866 #944

Merged
merged 116 commits into from
Nov 3, 2022
Merged

Release 2.0.866 #944

merged 116 commits into from
Nov 3, 2022

Commits on Jul 11, 2022

  1. macos build: use runtime instead of osx-x64

    Update DISTOUT variable in build.sh to use RUNTIME variable instead of
    hard-coding osx-x64.
    ldennington committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    5637aa9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #788 from ldennington/arm-fix

    macos build: use runtime instead of osx-x64
    ldennington authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    b83bf02 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Deleted outdated instruction for GitLab Support

    Deleted instruction concerning 'Expire access tokens' option when setting up OAuth app.
    cornejom authored Jul 13, 2022
    Configuration menu
    Copy the full SHA
    062310c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #790 from cornejom/gitlab-support-docs

    Delete outdated instruction for GitLab Support
    ldennington authored Jul 13, 2022
    Configuration menu
    Copy the full SHA
    e209b3d View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. release: consume auto-rotated SSL certificate

    Update release workflows to consume new autorotated SSL certificate. There
    are two main parts:
    
    1. Add the "SendX5c" : "true" key value pair to the contents of our ESRP
    Auth Json file. This allows us to use the new auto-rotating certificate
    without having to upload/manage it from our App Registration.i
    
    2. Remove the AZURE_AAD_ID_SSL secret/environment variable. The new
    certificate was generated with our main AZURE_AAD_ID app registration, so
    this extra ID is no longer needed.
    ldennington committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    f3aa617 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Merge pull request #797 from ldennington/ssl-cert-updates

    release: consume auto-rotated SSL certificate
    ldennington authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    2d79a03 View commit details
    Browse the repository at this point in the history
  2. build(deps): bump Newtonsoft.Json in /src/shared/Core

    Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.1.
    - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
    - [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.1)
    
    ---
    updated-dependencies:
    - dependency-name: Newtonsoft.Json
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    9313670 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2022

  1. Add broken link checking Action

    Also adjusts the entire workflow to only run if a PR or push contains changes to a markdown file
    wolf99 committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    5faf473 View commit details
    Browse the repository at this point in the history
  2. Ignore GitLab FAQ link

    wolf99 committed Jul 24, 2022
    1 Configuration menu
    Copy the full SHA
    8d6b33b View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Merge pull request #700 from wolf99/link-checker

    Add broken link checking Action
    mjcheetham authored Jul 25, 2022
    Configuration menu
    Copy the full SHA
    10935fb View commit details
    Browse the repository at this point in the history
  2. ci: use macos-latest image for CI builds

    The macos-10.15 image for CI builds is deprecated on GitHub Actions. We
    should update this to a supported image.
    
    Given we are actually running our release builds on macos-latest, we
    should probably be running CI on the same image too!
    mjcheetham committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    0b7bdd3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    162d657 View commit details
    Browse the repository at this point in the history
  4. diagnose: don't await Git exit on config list

    Do not wait for the Git process to exit until we start reading from
    the stdout stream, to prevent a deadlock. This is what we do in the
    product code too.
    mjcheetham committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    47ba58f View commit details
    Browse the repository at this point in the history
  5. Merge pull request #804 from mjcheetham/diagnose-hang

    Reorder Git config list process exit wait in diagnose command
    mjcheetham authored Jul 25, 2022
    Configuration menu
    Copy the full SHA
    77f7922 View commit details
    Browse the repository at this point in the history
  6. build(deps): bump DavidAnson/markdownlint-cli2-action from 5.1.0 to 6

    Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/DavidAnson/markdownlint-cli2-action) from 5.1.0 to 6.
    - [Release notes](https://github.com/DavidAnson/markdownlint-cli2-action/releases)
    - [Commits](DavidAnson/markdownlint-cli2-action@744f913...d199b6e)
    
    ---
    updated-dependencies:
    - dependency-name: DavidAnson/markdownlint-cli2-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Jul 25, 2022
    Configuration menu
    Copy the full SHA
    16d68da View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Merge pull request #800 from GitCredentialManager/dependabot/nuget/sr…

    …c/shared/Core/Newtonsoft.Json-13.0.1
    
    build(deps): bump Newtonsoft.Json from 12.0.3 to 13.0.1 in /src/shared/Core
    mjcheetham authored Jul 26, 2022
    Configuration menu
    Copy the full SHA
    80423fa View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Merge pull request #806 from GitCredentialManager/dependabot/github_a…

    …ctions/DavidAnson/markdownlint-cli2-action-6
    
    build(deps): bump DavidAnson/markdownlint-cli2-action from 5.1.0 to 6
    ldennington authored Jul 28, 2022
    Configuration menu
    Copy the full SHA
    5d869d9 View commit details
    Browse the repository at this point in the history
  2. build(deps): bump lycheeverse/lychee-action from 1.5.0 to 1.5.1

    Bumps [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) from 1.5.0 to 1.5.1.
    - [Release notes](https://github.com/lycheeverse/lychee-action/releases)
    - [Commits](lycheeverse/lychee-action@76ab977...4a5af7c)
    
    ---
    updated-dependencies:
    - dependency-name: lycheeverse/lychee-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Jul 28, 2022
    Configuration menu
    Copy the full SHA
    ee620eb View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Merge pull request #810 from GitCredentialManager/dependabot/github_a…

    …ctions/lycheeverse/lychee-action-1.5.1
    
    build(deps): bump lycheeverse/lychee-action from 1.5.0 to 1.5.1
    ldennington authored Aug 3, 2022
    1 Configuration menu
    Copy the full SHA
    d7fb42a View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. release: update Azure storage resource names

    The previous Azure resource architecture separated GCM and Microsoft Git
    resources into different Resource Groups. This led to redundancy - we were
    storing all our secrets, certificates, etc. in two places. These updates
    reflect the consolidation of these resources into the new esrp Resource
    Group.
    ldennington committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    8d7f639 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Merge pull request #819 from ldennington/update-azure-resource-names

    release: update Azure storage resource names
    ldennington authored Aug 6, 2022
    Configuration menu
    Copy the full SHA
    bdc20d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. build(deps): bump mjcheetham/update-homebrew from 1.1 to 1.2

    Bumps [mjcheetham/update-homebrew](https://github.com/mjcheetham/update-homebrew) from 1.1 to 1.2.
    - [Release notes](https://github.com/mjcheetham/update-homebrew/releases)
    - [Commits](mjcheetham/update-homebrew@v1.1...v1.2)
    
    ---
    updated-dependencies:
    - dependency-name: mjcheetham/update-homebrew
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    e1b6acd View commit details
    Browse the repository at this point in the history
  2. Merge pull request #826 from GitCredentialManager/dependabot/github_a…

    …ctions/mjcheetham/update-homebrew-1.2
    
    build(deps): bump mjcheetham/update-homebrew from 1.1 to 1.2
    ldennington authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    aefa730 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. homebrew release: update regex and remove PR

    Update release asset regex to specify runtime and version groups so that
    update-homebrew task can correctly detect version. Additionally, remove
    alwaysUsePullRequest parameter so that Homebrew releases become automatic.
    ldennington committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    1c08e84 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #798 from ldennington/homebrew-publish-m1-package

    macos arm64: Homebrew updates
    ldennington authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    07dd822 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. release: add installer validation

    Add basic installer validation to release pipeline for Windows,
    macOS (x64 only), and Linux (Debian package only). Validation runs the
    installers/any necessary setup and checks that the installed version
    matches the expected version.
    ldennington committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    d94c254 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Merge pull request #813 from ldennington/validate-installers

    release: add installer validation
    ldennington authored Aug 15, 2022
    Configuration menu
    Copy the full SHA
    a9fcb46 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. install from source: add support for Jammy Jellyfish

    The dotnet team recently added support for installing natively from Jammy feeds on
    Ubuntu 22.04:
    
    dotnet/core#7699
    
    This unfortunately created problems with our current install from source
    script, as it caused conflicts with
    the packages.microsoft.com feed we use for Debian/Ubuntu.
    
    This change modifies the Debian/Ubuntu dotnet install process to install from
    Jammy feeds for users on Ubuntu 22.04 and greater while continuing to use
    the packages.microsoft.com feed for Debian and older Ubuntu versions.
    ldennington committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    e3a0f0d View commit details
    Browse the repository at this point in the history
  2. install from source: clean up comments

    Update comments in the install from source script so that:
    
    1. Sentences begin with capital letters.
    2. Sentences end with punctuation.
    3. Comments are within 80 characters per line.
    ldennington committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    ba3e2b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2022

  1. workflows: auto-generate maintainer away issue

    Add a new workflow to create issues that will notify GCM users and
    contributors of when maintainers are away and the repo is not being
    actively monitored. This workflow is controlled by a `workflow_dispatch`
    trigger that requires both a start date and end date for maintainer
    absence before running.
    ldennington committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    8e8149b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Merge pull request #842 from ldennington/ooo-template

    workflows: auto-generate maintainer away issue
    ldennington authored Aug 22, 2022
    Configuration menu
    Copy the full SHA
    bf690c3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #839 from ldennington/ubuntu-jammy

    install from source: use native feeds for Ubuntu 22.04
    ldennington authored Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c2c0cdc View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. release: access Azure Storage Account with login credentials

    Use --auth-mode login command to access ESRP Azure Storage Account instead
    of AZURE_STORAGE_KEY. This allows us to reuse the git-fundamentals-esrp
    service principal login credentials we're already using for other
    resources and is a more secure mode of access than using the storage key.
    Lessley Dennington committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    8bc6801 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2022

  1. Merge pull request #851 from ldennington/remove-azure-storage-key

    release: access Azure Storage Account with login credentials
    ldennington authored Aug 27, 2022
    Configuration menu
    Copy the full SHA
    1f8e978 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f472dc7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a1921d5 View commit details
    Browse the repository at this point in the history
  4. 2 Configuration menu
    Copy the full SHA
    eac1057 View commit details
    Browse the repository at this point in the history
  5. Fix azrepos link

    wolf99 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    56685b6 View commit details
    Browse the repository at this point in the history
  6. Switch to ref style links

    wolf99 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    e727f49 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Add review suggestions

    wolf99 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    a2c4b85 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge pull request #680 from wolf99/ref-style-links

    Switch to reference style links
    ldennington authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    f230c46 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Unify line length across docs

    wolf99 committed Sep 9, 2022
    2 Configuration menu
    Copy the full SHA
    a9e5999 View commit details
    Browse the repository at this point in the history
  2. Break inline code line

    wolf99 committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    d226097 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2022

  1. Configuration menu
    Copy the full SHA
    d0f3537 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Update docs/gitlab.md

    Co-authored-by: Lessley Dennington <[email protected]>
    hickford and ldennington authored Sep 19, 2022
    Configuration menu
    Copy the full SHA
    86091b8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #862 from wolf99/doc-line-length

    Unify line length across docs
    ldennington authored Sep 19, 2022
    1 Configuration menu
    Copy the full SHA
    9393c1f View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Configuration menu
    Copy the full SHA
    6d078a8 View commit details
    Browse the repository at this point in the history
  2. avn: workaround a macOS window focus bug

    For some reason on macOS windows that are activated are not appearing on
    top, and get lost behind other application windows. The platform
    implementation on macOS is seemingly correctly calling the
    `makeKeyAndOrderFront` native windowing API, but it's not being made
    "key and front".
    
    Setting the "topmost" flag true (and then false again) brings our
    windows to the front, which is what we want.
    mjcheetham committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4fb392f View commit details
    Browse the repository at this point in the history
  3. avnui: include images in app app views in Avaloina UIs

    Include the images resource across all the Avalonia UI applications.
    mjcheetham committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    2530c28 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Configuration menu
    Copy the full SHA
    b8a85ec View commit details
    Browse the repository at this point in the history
  2. Merge pull request #867 from hickford/gitlab-config

    Add config for several popular GitLab instances to docs
    ldennington authored Sep 23, 2022
    Configuration menu
    Copy the full SHA
    4a73bc7 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. ui: add generic 'basic' credentials UI VM and command

    Add a generic credentials prompt view model and command for collecting
    username/passwords.
    mjcheetham committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1be714c View commit details
    Browse the repository at this point in the history
  2. ui: add Avalonia-based UI for generic cred prompt

    Add an Avalonia-based UI prompt for the generic/basic credential prompt.
    mjcheetham committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    b141c83 View commit details
    Browse the repository at this point in the history
  3. wpfui: add a WPF-based UI for generic cred prompt

    Add a WPF/Windows UI prompt for the generic/basic username and password
    prompt.
    mjcheetham committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    a1a358a View commit details
    Browse the repository at this point in the history
  4. basic: replace system UI with new UI helper

    Replace calls to the native system UI prompts with shelling out to the
    generic helper UI.
    mjcheetham committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    be9b83d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    feb02ce View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Merge pull request #871 from mjcheetham/generic-ui

    Add generic username/password UI to all platforms
    mjcheetham authored Sep 28, 2022
    Configuration menu
    Copy the full SHA
    00244fa View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. build(deps): bump actions/setup-dotnet from 2 to 3.0.0

    Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 2 to 3.0.0.
    - [Release notes](https://github.com/actions/setup-dotnet/releases)
    - [Commits](actions/setup-dotnet@v2...v3.0.0)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-dotnet
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Sep 29, 2022
    Configuration menu
    Copy the full SHA
    0d54aa8 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. release: fix Windows archives

    When we transitioned our release workflow to GitHub actions, we started
    using Powershell's `Compress-Archive` cmdlet to zip our Windows binaries.
    However, this unfortunately does not play nicely with `unzip` in WSL.
    Since we're publishing the archives from an Ubuntu machine, switch to
    creating the archives with the `zip` command in the default bash shell to
    correct the issue.
    Lessley Dennington committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    85b6104 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #884 from ldennington/fix-windows-zip

    release: fix Windows archives
    ldennington authored Sep 30, 2022
    Configuration menu
    Copy the full SHA
    eb67f53 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #883 from GitCredentialManager/dependabot/github_a…

    …ctions/actions/setup-dotnet-3.0.0
    
    build(deps): bump actions/setup-dotnet from 2 to 3.0.0
    ldennington authored Sep 30, 2022
    Configuration menu
    Copy the full SHA
    9b3bf45 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. build(deps): bump actions/setup-dotnet from 3.0.0 to 3.0.1

    Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 3.0.0 to 3.0.1.
    - [Release notes](https://github.com/actions/setup-dotnet/releases)
    - [Commits](actions/setup-dotnet@v3.0.0...v3.0.1)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-dotnet
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    21f9a80 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Issue 573 Write the results of GET command calls to the log

    Use the WriteDictionarySecrets() method to safely log the dictionary of data that will be written back to the calling Git process
    
    When it is necessary to follow the processing in GCM during a call from Git the GCM_TRACE environment variable can be used to print trace information to standard error, however the ultimate output of GET commands would not be included in this trace information
    
    This lack of visibility is especially problematic during multi-stage authentication such as OAuth, adding safe logging of the final output makes it possible to follow the GCM process in realtime from inputs to outputs during Git GET requests
    mminns committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0542166 View commit details
    Browse the repository at this point in the history
  2. Issue 573 Refactor Bitbucket implementation to allow for the support …

    …of Bitbucket DC's OAuth2 implementation
    
    The BitbucketAuthentication and BitbucketHostProvider remain the single points of entry to processing authentication for all Bitbucket hosts.
    
    Bitbucket DC and Bitbucket Cloud do not share common REST APIs or common OAuth2 implementations. The interface IBitbucketRestApi and abstract class BitbucketOAuth2Client effectively hide the differences in implementation from BitbucketAuthentication and BitbucketHostProvider
    
    The interface IBitbucketRestApi and abstract class BitbucketOAuth2Client provide clear extension points to implement OAuth2 support for Bitbucket DC
    mminns committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    e705869 View commit details
    Browse the repository at this point in the history
  3. Issue 573 Add support for OAuth2 for Bitbucket DC

    New implementations of the interface IBitbucketRestApi and abstract class BitbucketOAuth2Client provide client code for interacting with the Bitbucket DC REST API and OAuth2 implementation. Extending the BitbucketRestApiRegistry and OAuth2ClientRegistry to provide these Bitbucket DC implementations when a DC host is detected means BitbucketAuthentication and BitbucketHostProvider remain agnostic about which form of Bitbcuket host they are interacting with
    
    Prior to this feature users were limited to using Basic Auth or HTTP Access Tokens to interact securely with a Bitbucket DC instance. OAuth2 provides a better solution for SSO environments
    mminns committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    855c433 View commit details
    Browse the repository at this point in the history
  4. Issue 573 docs: Document the use and development of OAuth2 for Bitbuc…

    …ket DC
    
    Update docs/environment.md and docs/configuration.md to document the new configuration options for managing Bitbucket DC OAuth2 Client ID and Client Secrets
    
    Update docs//bitbucket-development.md to document how to create a test Bitbucket DC environment and OAuth2 setup
    mminns committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    6c28d76 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. build(deps): bump actions/checkout from 3 to 3.1.0

    Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 3.1.0.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@v3...93ea575)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    930c02a View commit details
    Browse the repository at this point in the history
  2. docs: use short link for Linux install src

    Use a short link for the Linux install from source script.
    
    Signed-off-by: Matthew John Cheetham <[email protected]>
    mjcheetham committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    c2f6826 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Updates RFC links to authoritative URL

    The current URLs use an outdated source.
    
    The rfc-editor.org site is stated to be the authoritative source, see aaragraph 3 on https://www.ietf.org/standards/rfcs/.
    
    The redirection used at the existing URL cause the later versions of the link checker to fail for the instances in the documentation. However, instances in the source code comments have also been updated.
    wolf99 committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    351effa View commit details
    Browse the repository at this point in the history
  2. Replace githubusercontent images

    Fixes #863
    wolf99 committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    3756bc2 View commit details
    Browse the repository at this point in the history
  3. Document how to lint documentation

    Adds a brief section to the `docs/document.md` on how linting of documents is done.
    wolf99 committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    e4c1926 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Merge pull request #887 from GitCredentialManager/dependabot/github_a…

    …ctions/actions/setup-dotnet-3.0.1
    
    build(deps): bump actions/setup-dotnet from 3.0.0 to 3.0.1
    ldennington authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    093aa0f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #892 from GitCredentialManager/mjcheetham/linux-in…

    …stall-link
    
    docs: use short link for Linux install src
    mjcheetham authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    7c3a844 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #893 from wolf99/update-rfc-links

    Updates RFC links to authoritative URL
    mjcheetham authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    a8fd6f0 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #894 from wolf99/github-usercontent-images

    Replace githubusercontent images
    mjcheetham authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    0d591c3 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #895 from wolf99/document-doc-linting

    Document how to lint documentation
    mjcheetham authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    3392430 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #607 from mminns/issue/573-OAuth2-support-for-Bitb…

    …ucket-DC
    
    Issue/573 OAuth2 support for Bitbucket DC
    mjcheetham authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    228f7cd View commit details
    Browse the repository at this point in the history
  7. Merge pull request #890 from GitCredentialManager/dependabot/github_a…

    …ctions/actions/checkout-3.1.0
    
    build(deps): bump actions/checkout from 3 to 3.1.0
    ldennington authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    44534db View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. release: publish gcm as dotnet tool

    Add a new `DotnetTool` project containing the needed files to publish GCM
    as a cross-platform dotnet tool. Additionally, update GCM to use helper
    dlls if exes are not found in the Application directory. At present, dlls
    are only used in the dotnet tool scenario to minimize the package size and
    to make it cross-platform compatible.
    Lessley Dennington committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    715eef1 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Merge pull request #886 from ldennington/dotnet-tool

    release: package gcm as dotnet tool
    ldennington authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    89b565a View commit details
    Browse the repository at this point in the history
  2. dotnet tool: rename package

    Change the name and author of the dotnet tool package from
    GitCredentialManager.Cli to git-credential-manager. The reason for this
    change is that we were able to transfer ownership of this package (which
    was previously owned by JetBrains) to the git-credential-manager
    organization on NuGet.org.  There should not be any customer impact
    related to this change, as the GitCredentialManager.Cli package had yet
    to be published.
    Lessley Dennington committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    e62c368 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #901 from ldennington/rename-dotnet-tool-package

    dotnet tool: rename package
    ldennington authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    fb52269 View commit details
    Browse the repository at this point in the history
  4. build(deps): bump actions/setup-dotnet from 3.0.1 to 3.0.2

    Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 3.0.1 to 3.0.2.
    - [Release notes](https://github.com/actions/setup-dotnet/releases)
    - [Commits](actions/setup-dotnet@v3.0.1...v3.0.2)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-dotnet
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    4abff68 View commit details
    Browse the repository at this point in the history
  5. windows: include git-credential-manager-ui.exe in installer

    We forget to include the core UI helper (WPF) in the Windows installer
    manifest.. add it!
    mjcheetham committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    0792d7b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. gcm: rename entry executable to drop -core suffix

    Rename the main entry executable from git-credential-manager-core(.exe)
    to simply git-credential-manager(.exe), now that the older GCM4W has
    been removed from the Git for Windows project as an option (and the GCMC
    project has been renamed).
    
    We do not rename the Debian package ID, nor the Homebrew Cask name yet
    as this will require more thought for migration.
    mjcheetham committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    a34ee31 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #903 from mjcheetham/fix-winstall

    Include git-credential-manager-ui.exe in installer
    mjcheetham authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    89c4883 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #902 from GitCredentialManager/dependabot/github_a…

    …ctions/actions/setup-dotnet-3.0.2
    
    build(deps): bump actions/setup-dotnet from 3.0.1 to 3.0.2
    ldennington authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    74b3d6a View commit details
    Browse the repository at this point in the history
  4. build: explicitly pass version and conf args to pack-tool.sh

    Explicitly pass the version and build configuration to the dotnet tool
    packaging script. Also revert to a default Debug config for local
    builds; this is consistent with all other artifacts in the build for dev
    (macOS pkg, Windows installers, deb, etc)
    mjcheetham committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    7e2b209 View commit details
    Browse the repository at this point in the history
  5. dotnet-tool: add GCM icon to tool nuget package

    Add the GCM icon to the NuGet package used for the dotnet tool.
    The image is copied to the root of the package under a new `images`
    directory (/images). The tool payload continues to be copied under the
    required `/tool/net6.0/any` directory.
    
    Modify the pack-tool.sh script to keep all build output under the /out
    directory of the repository (which is in .gitignore). Output from
    running pack-tool.sh now looks like this:
    
    .
    └── out
        └── shared
            └── DotnetTool
                └── nupkg
                    └── Debug
                        ├── git-credential-manager.$VERSION.nupkg
                        ├── images       # icon
                        ├── payload      # dotnet publish output
                        └── payload.sym  # pdbs
    
    The contents of the NuGet package looks like this:
    
    .
    ├── [Content_Types].xml
    ├── _rels
    ├── git-credential-manager.nuspec
    ├── images
    │   └── icon.png          # copied from the output images/ dir
    ├── package
    │   └── services
    │       └── metadata/...
    └── tools
        └── net6.0
            └── any/...       # copied from the output payload/ dir
    mjcheetham committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    65d2d88 View commit details
    Browse the repository at this point in the history
  6. winui: fix up a bug that was introduced in an earlier PR

    Fix a bug that was introduced in an earlier PR to build the Core UI
    helper (WPF) for Windows. We don't need to specify the TFM or RID for
    these projects.
    mjcheetham committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    3a46451 View commit details
    Browse the repository at this point in the history
  7. dotnet-tool: include core UI helper in package

    We missed the core UI helper from the dotnet tool package - include it!
    mjcheetham committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    bdb3a9a View commit details
    Browse the repository at this point in the history
  8. Merge pull request #905 from mjcheetham/pkgicon

    Add icon to dotnet tool NuGet package
    mjcheetham authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    7047f48 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. Update markdownlint-cli2-action to 7.0.0

    This required fixing some newly found lint issues.
    
    Additionally some issues are in files (workflow templates) that are structured in such a way that do not easily allow correction, so I have adjusted the linter configuration to ignore these files for now. They could instead be corrected in a later commit.
    wolf99 committed Oct 16, 2022
    Configuration menu
    Copy the full SHA
    3ccaf44 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Configuration menu
    Copy the full SHA
    17af723 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. gcm: create symlinks and warn message for gcmcore exec

    Create symlinks and shim/copy-executables for the original exec
    "git-credential-manager-core(.exe)" name for consumers who have not
    updated to the new name.
    
    We detect if the consumer is launching us via the "-core" symlink or
    executable shim by consulting the platform-native APIs to get the
    original "argv[0]". All of the .NET APIs sadly don't give us the real
    "argv[0]", so we need to use native APIs...
    
    If we detect use of the old name, print a warning that the user should
    update their configuration, and a help link for more information.
    mjcheetham committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    fa2cc18 View commit details
    Browse the repository at this point in the history
  2. docs: add documentation about the GCM.exe rename

    Add documentation with information about the GCM.exe rename, and how to
    fix-up any configuration after the change.
    
    The aka.ms/gcm/rename shortlink points to this document.
    mjcheetham committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    a47e1ce View commit details
    Browse the repository at this point in the history
  3. Rename entry executable to drop "-core" suffix (#551)

    Rename the main entry executable from
    `git-credential-manager-core(.exe)` to simply
    `git-credential-manager(.exe)`, now that the older GCM4W has been
    removed from the Git for Windows project as an option (and the GCMC
    project has been renamed).
    
    We do **not** rename the Debian package ID, nor the Homebrew Cask name
    yet as this will require more thought forr migration.
    
    To help with migration somewhat, create symlinks and
    shim/copy-executables for the original executable name
    "git-credential-manager-core(.exe)" for consumers who have not updated
    to the new version.
        
    We detect if the consumer is launching us via the "-core" symlink or
    executable shim by consulting the platform-native APIs to get the
    original "argv[0]". All of the .NET APIs sadly don't give us the real
    "argv[0]", so we need to use native APIs...
        
    If we detect use of the old name, print a warning that the user should
    update their configuration, and a help link for more information.
    mjcheetham authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    02204ac View commit details
    Browse the repository at this point in the history
  4. Update markdownlint-cli2-action to 7.0.0 (#910)

    This required fixing some newly found lint issues.
    
    Additionally some issues are in files (workflow templates) that are
    structured in such a way that do not easily allow correction, so I have
    adjusted the linter configuration to ignore these files for now. They
    could instead be corrected in a later commit.
    ldennington authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    3ffa190 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    15b522f View commit details
    Browse the repository at this point in the history
  6. build: fix/speed-up build graph dependencies

    When building the entire solution, we need to ensure the various
    "Installer.<OS>" and "Packaging.<OS>" projects are not built at the same
    time as other projects, especially on Windows, where we may hit file
    locking problems.
    
    The installer projects call a build script internally that calls a
    `dotnet publish` on various projects. By making the installer projects
    reference (but not consume) the dependent projects we ensure MSBuild
    won't build them until the end, and prevent file access errors.
    
    At the same time, we can probably remove the "-m:1" flags that tell
    MSBuild to only build one project at a time.
    mjcheetham committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    990b647 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. windows: add missing DllImport attribute to LocalFree (#923)

    Accidentally left off the `[DllImport]` attribute when adding this
    `extern`.. now it'll actually point to the correct function in the DLL.
    mjcheetham authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    f0276e0 View commit details
    Browse the repository at this point in the history
  2. Add KDE Gitlab (invent.kde.org) instance to the list of supported ser…

    …vices (#920)
    
    This adds support for another popular OSS project (KDE) to Git
    Credential Manager.
    mjcheetham authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    04631c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. build(deps): bump actions/setup-dotnet from 3.0.2 to 3.0.3

    Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 3.0.2 to 3.0.3.
    - [Release notes](https://github.com/actions/setup-dotnet/releases)
    - [Commits](actions/setup-dotnet@v3.0.2...v3.0.3)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-dotnet
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    97e9e88 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. build(deps): bump actions/setup-dotnet from 3.0.2 to 3.0.3 (#932)

    build(deps): bump actions/setup-dotnet from 3.0.2 to 3.0.3
    ldennington authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    d4f031f View commit details
    Browse the repository at this point in the history
  2. build: fix/speed-up build graph dependencies (#924)

    When building the entire solution, we need to ensure the various
    "Installer.<OS>" and "Packaging.<OS>" projects are not built at the same
    time as other projects, especially on Windows, where we may hit file
    locking problems.
    
    The installer projects call a build script internally that calls a
    `dotnet publish` on various projects. By making the installer projects
    reference (but not consume) the dependent projects we ensure MSBuild
    won't build them until the end, and prevent file access errors.
    
    At the same time, we can probably remove the "-m:1" flags that tell
    MSBuild to only build one project at a time.
    mjcheetham authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8261c81 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. docs: separate install information from README

    In an effort to make our README more concise, move GCM install
    instructions into a new install.md file. Additionally, add a section
    detailing how to install GCM as a dotnet tool.
    ldennington committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    86459c7 View commit details
    Browse the repository at this point in the history
  2. docs: separate additional resources from README

    In an effort to make our README more concise, move additional resources
    into a new docs/README.md file.
    ldennington committed Nov 2, 2022
    1 Configuration menu
    Copy the full SHA
    fc8659d View commit details
    Browse the repository at this point in the history
  3. docs: migrate install/resource README sections to new files (#937)

    In an effort to make the `README` more concise, move install
    instructions/additional resources into new `install.md` and
    `docs/README.md` files.
    mjcheetham authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    d54fea6 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Fix docs/x.md relative links

    Some link references were broken, e.g. `[gcm-wsl]: docs/wsl.md` led to `.../docs/docs/wsl.md` (note 2 `docs` in path) This PR fixes those links to properly point to `.../docs/x.md` (1 `docs` in path)
    rendall authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    dcddb25 View commit details
    Browse the repository at this point in the history
  2. Fix docs/x.md relative links (#938)

    Some link references were broken, e.g. `[gcm-wsl]: docs/wsl.md` led to
    `.../docs/docs/wsl.md` (note 2 `docs` in path) This PR fixes those links
    to properly point to `.../docs/x.md` (1 `docs` in path)
    ldennington authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    0097b9d View commit details
    Browse the repository at this point in the history
  3. docs: absolute --> relative paths

    Change absolute paths to relative paths in install.md to remain
    consistent with the style used in other files.
    ldennington committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    fef64ec View commit details
    Browse the repository at this point in the history
  4. diagnose: always use IHttpClientFactory for diagnose

    The Network diagnostic currently makes two passes of the tests, one
    using a 'raw' `HttpClient` and another using one created by the product
    `HttpClientFactory`.
    
    However, we've not actually been using the factory-built client in the
    tests! Furthermore, the raw HTTP client will not exercise test correctly
    if the machine is behind a corporate proxy, so let's just drop that
    option.
    mjcheetham committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    da646ea View commit details
    Browse the repository at this point in the history
  5. release: remove automatic workflow trigger

    Remove the trigger to automatically run the release workflow when
    changes are merged to the release branch. This will give us better
    control over our release process and allow us to make changes to the
    branch if needed without running the workflow.
    ldennington committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    1de6464 View commit details
    Browse the repository at this point in the history
  6. diagnose: always use IHttpClientFactory for diagnose (#942)

    The Network diagnostic currently makes two passes of the tests, one
    using a 'raw' `HttpClient` and another using one created by the product
    `HttpClientFactory`.
    
    However, we've not actually been using the factory-built client in the
    tests! Furthermore, the raw HTTP client will not exercise test correctly
    if the machine is behind a corporate proxy, so let's just drop that
    option.
    
    Fixes #927
    ldennington authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    8988107 View commit details
    Browse the repository at this point in the history
  7. Update README.md

    vtbassmatt authored and ldennington committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    a665e70 View commit details
    Browse the repository at this point in the history
  8. release: remove automatic workflow trigger (#943)

    Remove the trigger to automatically run the release workflow when
    changes are merged to the release branch. This will give us better
    control over our release process and allow us to make changes to the
    branch if needed without running the workflow.
    ldennington authored Nov 3, 2022
    1 Configuration menu
    Copy the full SHA
    452981c View commit details
    Browse the repository at this point in the history