-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document criteria for proposing new licenses #316
Conversation
Believe this is ready for 👀, especially from @mlinksva. I added tests to enforce the proposed license addition criteria. All our existing licenses meet the criteria. Excluding GitHub search results (which can't be retrieved programmatically), there are currently 104 potentially "approved" licenses:
By that same logic, there are 83 potential additions:
|
|
||
context "industry approval" do | ||
|
||
# FSF approved the clear BSD, but doesn't use it's SPDX ID or Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo: "it's" --> "its". Also, shouldn't "Clear" be capitalized?
Looks good overall! See line notes for minor comments. |
Thanks for the feedback @mlinksva. Believe I implemented all your suggestions, but glad to continue to improve if you have any more / I missed any / things change once we start using it. 😄 |
Document criteria for proposing new licenses
This pull request documents @mlinksva's suggestions for new license criteria over in #315. Specifically:
If there's rough consensus that the above is good criteria, I'll adapt the existing tests to confirm the above (and run them against the existing license list). I believe SPDXiness is already checked, as is OSI approval, with a few whitelisted exceptions.