Add script to check approval of a license. #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This output is a bit odd: |
Are you talking about the alignment? The colon in the title? |
|
Sorry for not being explicit. MIT is FSF approved. I realize not needed for eligibility calculation. But probably better to just not display if short-circuited (I haven't looked to see whether that's actually why the output is saying MIT isn't FSF approved). |
|
OK, it isn't short-circuited, but FSF calls it Expat. I don't know that it is really important that this script has correct output. Feel free to ignore. |
benbalter
added a commit
that referenced
this pull request
Jan 18, 2016
Add script to check approval of a license.
|
Thanks @mlinksva. It's been helping me with the open issues, and glad to keep iterating on it as we find those types of edge cases (BSD 3-clause being another one). |
wking
added a commit
to wking/choosealicense.com
that referenced
this pull request
Jan 3, 2018
Avoid: $ ./script/check-approval MIT ./script/check-approval:55:in `<main>': undefined local variable or method `license_ids' for main:Object (NameError) The license_ids line was added in e505eb8 (check if license is aleady a license, 2016-01-18, github#318), but license_ids was removed from the helper in b99e7ab (replace 'id' variables with 'spdx_lcase' to minimize confusion, 2016-06-01, github#424). This commit restores the old code locally, since this script is the only consumer.
wking
added a commit
to wking/choosealicense.com
that referenced
this pull request
Jan 3, 2018
The previous case-insensitive matching was removed in e5f46fa (test required spdx-ids against data from spdx, 2016-05-25, github#418). That commit was designed [1] to allow case-sensitive matching as discussed in [2]. But while I'm in favor of case-sensitive keys in spdx_list, the case-sensitive match breaks script/check-approval which downcases its argument since it was added in 8e56bb8 (add script/check-approval, 2016-01-18, github#318). [1]: github#418 (comment) [2]: licensee/licensee#72
wking
added a commit
to wking/choosealicense.com
that referenced
this pull request
Jan 3, 2018
The previous case-insensitive matching was removed in e5f46fa (test required spdx-ids against data from spdx, 2016-05-25, github#418). That commit was designed [1] to allow case-sensitive matching as discussed in [2]. But while I'm in favor of case-sensitive keys in spdx_list, the case-sensitive match breaks script/check-approval which downcases its argument since it was added in 8e56bb8 (add script/check-approval, 2016-01-18, github#318). There are more notes on SPDX's plans for case sensitivity in [3], so we should see a clearer policy there soon. I'm arguing for case-sensitive *display* with optional case-insensitive matching. I am optimistic that the SPDX will at least agree not to register short IDs that only differ by case, which is all we need to make this case-insensitive match safe here. [1]: github#418 (comment) [2]: licensee/licensee#72 [3]: spdx/spdx-spec#63
wking
added a commit
to wking/choosealicense.com
that referenced
this pull request
Jan 3, 2018
Avoid: $ ./script/check-approval MIT ./script/check-approval:55:in `<main>': undefined local variable or method `license_ids' for main:Object (NameError) The license_ids line was added in e505eb8 (check if license is aleady a license, 2016-01-18, github#318), but license_ids was removed from the helper in b99e7ab (replace 'id' variables with 'spdx_lcase' to minimize confusion, 2016-06-01, github#424). This commit restores the old code locally, since this script is the only consumer.
wking
added a commit
to wking/choosealicense.com
that referenced
this pull request
Jan 3, 2018
Avoid: $ ./script/check-approval MIT ./script/check-approval:55:in `<main>': undefined local variable or method `license_ids' for main:Object (NameError) The license_ids line was added in e505eb8 (check if license is aleady a license, 2016-01-18, github#318), but license_ids was removed from the helper in b99e7ab (replace 'id' variables with 'spdx_lcase' to minimize confusion, 2016-06-01, github#424). This commit restores the old code locally, since this script is the only consumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #316, this adds a quick script to check the approval of a given license to help with responding to issues proposing new licenses be added.
Example output: