Commits on Jan 3, 2018

1. spec_helper: Restore case-insensitive matching in find_spdx …

   The previous case-insensitive matching was removed in e5f46fa (test
   required spdx-ids against data from spdx, 2016-05-25, github#418).  That
   commit was designed [1] to allow case-sensitive matching as discussed
   in [2].  But while I'm in favor of case-sensitive keys in spdx_list,
   the case-sensitive match breaks script/check-approval which downcases
   its argument since it was added in 8e56bb8 (add
   script/check-approval, 2016-01-18, github#318).
   
   There are more notes on SPDX's plans for case sensitivity in [3], so
   we should see a clearer policy there soon.  I'm arguing for
   case-sensitive *display* with optional case-insensitive matching.  I
   am optimistic that the SPDX will at least agree not to register short
   IDs that only differ by case, which is all we need to make this
   case-insensitive match safe here.
   
   [1]: github#418 (comment)
   [2]: licensee/licensee#72
   [3]: spdx/spdx-spec#63

   

   wking committed Jan 3, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for af78adb
   • Browse repository at this point

   Copy the full SHA

   af78adb View commit details

   Browse the repository at this point in the history