-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pages-gem.yml #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsusdere Sorry for stupid questions, but unless I'm missing something this wasn't adapted when copied over from github/pages-gem:
gem build github-pages.gemspec | ||
- name: Publish | ||
run: | | ||
gem push github-pages.gem --key ${{ secrets.PAGES_GEM_PUBLISH }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Does a release here in
jekyll-commonmark-ghpages
warrant publishinggithub-pages
? -
Since there's no
github-pages.gemspec
here, onlyjekyll-commonmark-ghpages.gemspec
, won't this fail? (Maybe I'm horribly missing something, sorry if that's the case…) -
Bonus question, since the resulting gem has a version in its filename, you won't have
package-name.gem
but e. g.package-name-0.4.0.gem
to push. Won't you need some more output magic to push the correct filename? — ah yea this: Fix release script pages-gem#903 + Another publish script fix pages-gem#904
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out that yeah this workflow will not work as is 😁. Will fix it when I get a chance for next release (we copied it in lots of repos actually!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions/starter-workflows
has a neat trick ci/gem-push.yml#L39-L48 if you don't want to manage gem file names in every repo separately… simply wildcarding it everywhere;)
gem build github-pages.gemspec | |
- name: Publish | |
run: | | |
gem push github-pages.gem --key ${{ secrets.PAGES_GEM_PUBLISH }} | |
gem build *.gemspec | |
- name: Publish | |
run: | | |
gem push *.gem --key ${{ secrets.PAGES_GEM_PUBLISH }} |
Adds workflow to automate publishing the gem to RubyGems