Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pages-gem.yml #34

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Create pages-gem.yml #34

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b0c740
Create pages-gem.yml
tsusdere Jan 2, 2024
c9a681d
Update pages-gem.yml
tsusdere Jan 2, 2024
ad215da
Update pages-gem.yml
tsusdere Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/pages-gem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Publish Gem

on:
release:
types: [released]

jobs:
release:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.2'
- name: Build gem
run: |
gem build github-pages.gemspec
- name: Publish
run: |
gem push github-pages.gem --key ${{ secrets.PAGES_GEM_PUBLISH }}
Comment on lines +19 to +22
Copy link

@janbrasna janbrasna Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Does a release here in jekyll-commonmark-ghpages warrant publishing github-pages?

  2. Since there's no github-pages.gemspec here, only jekyll-commonmark-ghpages.gemspec, won't this fail? (Maybe I'm horribly missing something, sorry if that's the case…)

  3. Bonus question, since the resulting gem has a version in its filename, you won't have package-name.gem but e. g. package-name-0.4.0.gem to push. Won't you need some more output magic to push the correct filename? — ah yea this: Fix release script pages-gem#903 + Another publish script fix pages-gem#904

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out that yeah this workflow will not work as is 😁. Will fix it when I get a chance for next release (we copied it in lots of repos actually!).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/starter-workflows has a neat trick ci/gem-push.yml#L39-L48 if you don't want to manage gem file names in every repo separately… simply wildcarding it everywhere;)

Suggested change
gem build github-pages.gemspec
- name: Publish
run: |
gem push github-pages.gem --key ${{ secrets.PAGES_GEM_PUBLISH }}
gem build *.gemspec
- name: Publish
run: |
gem push *.gem --key ${{ secrets.PAGES_GEM_PUBLISH }}