Handle multiline ERB comments

Fixes #431
glebm · Mar 26, 2022 · c2c257d · c2c257d
1 parent eb97672
commit c2c257d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/i18n/tasks/scanners/erb_ast_processor.rb b/lib/i18n/tasks/scanners/erb_ast_processor.rb
@@ -70,9 +70,16 @@ def transform_misparsed_comment(node)
         node.children[2]&.type == :code &&
         node.children[3].nil?
       code_node = node.children[2]
+
+      # Prepend # to each line to make it a valid Ruby comment.
+      code = code_node.children[0].split("\n").map do |line|
+        next line if line =~ /^\s*#/
+        "##{line}"
+      end.join("\n")
+
       node.updated(
         nil,
-        [nil, nil, code_node.updated(nil, ["##{code_node.children[0]}"]), nil]
+        [nil, nil, code_node.updated(nil, [code]), nil]
       )
     end
 

diff --git a/spec/fixtures/used_keys/app/views/application/show.html.erb b/spec/fixtures/used_keys/app/views/application/show.html.erb
@@ -23,4 +23,8 @@ I18n.t("this_should_not")
   <% end %>
 
   <%# this should not fail: ' %>
+
+  <%# this is a multiline comment
+  it's totally fine
+  nothing should fail %>
 </h3>