-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser Error when erb comment tags span multiple lines #431
Comments
Where is this syntax specified? Naively, it seems invalid, since |
/cc @davidwessman |
Released v1.0.5 |
https://ruby-doc.org/stdlib-3.1.1/libdoc/erb/rdoc/ERB.html From
|
Thank you for the quick turn-around! |
I noticed (initially when checking 1.0.2, but confirmed still in 1.0.4) an issue where multi-line comment tags like the following
are recognized correctly by ERB and render correctly (don't render at all, the entire content is commented), but a parser error is raised when running 18n tasks
Modifying the comment tag to include a
#
on each comment line resolves the parser error (tests run successfully), so we can work around this if needed, but indicates a drift between the ERB syntax and that recognized by the i18n tasks.Originally we expected this was related to #430 (since the tag starts
<%#
and not<% #
that was also possibly related), but the same problem was seen after updating to 1.0.4.The text was updated successfully, but these errors were encountered: