Fixes parsing of ERB comments without a space #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ERB parser we're using misparses comments of the form:
<%# ... #>
(no space between % and #)
With a space the AST is:
s(:erb, nil, nil,
s(:code, " # this should not fail: ' "), nil)
Without a space the AST is:
s(:erb,
s(:indicator, "#"), nil,
s(:code, " this should not fail: ' "), nil)
The latter AST causes a crash when parsing the `:code` node as Ruby.
Works around the issue by transforming the latter AST to the former.
Fixes #429
davidwessman
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ERB parser we're using misparses comments of the form:
(no space between % and #)
With a space the AST is:
Without a space the AST is:
The latter AST causes a crash when parsing the
:codenode as Ruby.Works around the issue by transforming the latter AST to the former.
Fixes #429