Skip to content

Commit

Permalink
Remove deprecated config APIs. (#847)
Browse files Browse the repository at this point in the history
* Remove deprecated config APIs.

* Update changelog.

* Add issues to changelog.

* Remove unnecessary newline.

Co-authored-by: Bradley Dice <[email protected]>
  • Loading branch information
vyasr and bdice authored Nov 6, 2022
1 parent db2b9fa commit 14205d3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 31 deletions.
2 changes: 1 addition & 1 deletion changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Removed
- The ability to pass indexes to various ``Project`` methods (#599).
- The following ``JobsCursor`` methods: ``groupbydoc``, ``next`` (#601, #604).
- The ``Project.config`` property is no longer mutable. Use the command line ``$ signac config`` to modify configuration (#608, #246, #244).
- The following config related functions: ``get_config``, ``search_standard_dirs`` (#674).
- The following config related functions: ``get_config``, ``load_config``, ``read_config_file``, ``search_standard_dirs`` (#674, #753, #789, #847).
- ``Project`` subclasses can no longer define a ``Job`` subclass to use (#588, #693).
- The ``Collection`` class (#664, #667, #683).
- The ``project`` CLI subcommand (#752).
Expand Down
30 changes: 0 additions & 30 deletions signac/common/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
import logging
import os

from ..common.deprecation import deprecated
from ..version import __version__
from .configobj import ConfigObj, ConfigObjError
from .errors import ConfigError
from .validate import cfg, get_validator
Expand Down Expand Up @@ -114,20 +112,6 @@ def _read_config_file(filename):
return config


@deprecated(
deprecated_in="1.8",
removed_in="2.0",
current_version=__version__,
details=(
"The read_config_file method is deprecated. Configs should only be "
"accessed via a Project instance.",
),
)
def read_config_file(filename):
"""Read a configuration file."""
return _read_config_file(filename)


def _load_config(path=None):
"""Load configuration from a project directory.
Expand Down Expand Up @@ -158,20 +142,6 @@ def _load_config(path=None):
return config


@deprecated(
deprecated_in="1.8",
removed_in="2.0",
current_version=__version__,
details=(
"The load_config method is deprecated. Configs should only be "
"accessed via a Project instance.",
),
)
def load_config(root=None):
"""Load configuration, searching upward from a root path."""
return _load_config(root)


class Config(ConfigObj):
"""Manages configuration for a signac project."""

Expand Down

0 comments on commit 14205d3

Please sign in to comment.