Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated config APIs. #847

Merged
merged 5 commits into from
Nov 6, 2022
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 2, 2022

Description

This PR deletes config APIs that are deprecated.

Motivation and Context

Resolves #789. The outstanding question is what to do about the Config class and whether it needs to remain public.

Checklist:

@vyasr vyasr added the refactor Code refactoring label Nov 2, 2022
@vyasr vyasr self-assigned this Nov 2, 2022
@vyasr vyasr requested review from a team as code owners November 2, 2022 04:37
@vyasr vyasr requested review from kidrahahjo and klywang and removed request for a team November 2, 2022 04:37
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #847 (88edae6) into master (db2b9fa) will decrease coverage by 0.70%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
- Coverage   85.75%   85.04%   -0.71%     
==========================================
  Files          51       51              
  Lines        4683     4675       -8     
  Branches      923      923              
==========================================
- Hits         4016     3976      -40     
- Misses        480      519      +39     
+ Partials      187      180       -7     
Impacted Files Coverage Δ
signac/common/config.py 89.23% <ø> (+1.55%) ⬆️
signac/common/deprecation/__init__.py 0.00% <0.00%> (-37.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a stab at the Config object in a separate PR. There are a few awkward bits to refactor there.

@vyasr vyasr merged commit 14205d3 into master Nov 6, 2022
@vyasr vyasr deleted the refactor/remove_deprecated_config_apis branch November 6, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove remaining config API
2 participants