fix: if no next interact was present, we would not get events #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was because the display:none caused us to not have any events. The reason to add this is to not 'eat' mouse events from the 'next' interact. However, a better solution is to have the 'next', be added second in the DOM.
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 58.00% 58.00%
=======================================
Files 5 5
Lines 100 100
=======================================
Hits 58 58
Misses 42 42 Continue to review full report at Codecov.
|
We did not clean up the next view, leaving the interact basically attached. But when removing, all other events from other listeners were removed because that is how d3.on works if you don't use namespaced event names.
|
Some cleanups and namespaced events solves all issues for glue-viz/glue-jupyter#213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was because the display:none caused us to not have any events.
The reason to add this is to not 'eat' mouse events from the 'next'
interact. However, a better solution is to have the 'next', be added
second in the DOM.
Fixes glue-viz/glue-jupyter#213 for when
nextis set to None