Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise DeprecationWarning for BqplotScatterLayerState #379

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

dhomeier
Copy link
Contributor

@dhomeier dhomeier commented Aug 2, 2023

Description

Fixing #375, which accidentally ended up with raising a UserWarning

@dhomeier dhomeier added bug Something isn't working bqplot-viewers skip-changelog Changelog entry not needed or added manually labels Aug 2, 2023
@dhomeier dhomeier requested a review from astrofrog August 2, 2023 16:04
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1823e1b) 86.65% compared to head (5327bd8) 86.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files          89       89           
  Lines        4940     4940           
=======================================
  Hits         4281     4281           
  Misses        659      659           
Files Changed Coverage Δ
glue_jupyter/bqplot/scatter/layer_artist.py 90.86% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog astrofrog merged commit f0270ab into glue-viz:main Aug 2, 2023
23 checks passed
@dhomeier dhomeier deleted the bqsls-raise-deprecate branch August 4, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bqplot-viewers bug Something isn't working skip-changelog Changelog entry not needed or added manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants