Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: glue-jupyter compatibility for import #2336

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 2, 2023

Description

Blocked by:

MNT: glue-jupyter compatibility for import for glue-viz/glue-jupyter#379 . If we end up needing to bump minversion of glue-jupyter to 0.18 anyway for other reasons, then we do not need the compatibility layer and can just switch straight to new import.

TST: Temporarily ignore DeprecationWarning from astropy/numpy dev that is already fixed in astropy/astropy#15116 . This should go away on its own when astropy uploads new dev wheel and then we can remove the ignore added here. I just need this out of the way to see if we get all the glue-jupyter stuff.

TST: Use legacy numpy print option so we don't have to deal with the new print, yet.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Aug 2, 2023
@pllim pllim added this to the 3.7 milestone Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4bcc1b1). Click here to learn what that means.
Patch coverage: 80.00% of modified lines in pull request are covered.

❗ Current head 25d5738 differs from pull request most recent head 2956f06. Consider uploading reports for the commit 2956f06 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2336   +/-   ##
=======================================
  Coverage        ?   90.53%           
=======================================
  Files           ?      152           
  Lines           ?    17370           
  Branches        ?        0           
=======================================
  Hits            ?    15726           
  Misses          ?     1644           
  Partials        ?        0           
Files Changed Coverage Δ
...nfigs/default/plugins/plot_options/plot_options.py 93.35% <75.00%> (ø)
jdaviz/configs/default/plugins/viewers.py 96.47% <75.00%> (ø)
jdaviz/core/astrowidgets_api.py 97.18% <80.00%> (ø)
jdaviz/utils.py 88.88% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim

This comment was marked as resolved.

@pllim

This comment was marked as resolved.

@pllim pllim added the 💤 backport-v3.6.x on-merge: backport to v3.6.x label Aug 11, 2023
@pllim pllim modified the milestones: 3.7, 3.6.2 Aug 11, 2023
@pllim pllim marked this pull request as ready for review August 11, 2023 23:34
@pllim
Copy link
Contributor Author

pllim commented Aug 11, 2023

Should be uncontroversial. Nothing we can do about this anyway. Friday night YOLO!

@pllim pllim merged commit d731eb3 into spacetelescope:main Aug 11, 2023
16 of 18 checks passed
@pllim pllim deleted the glupyter-import-changed branch August 11, 2023 23:35
@lumberbot-app

This comment was marked as resolved.

pllim added a commit to pllim/jdaviz that referenced this pull request Aug 12, 2023
…nged

MNT: glue-jupyter compatibility for import
(cherry picked from commit d731eb3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two 💤 backport-v3.6.x on-merge: backport to v3.6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant