EXP: Add colorbar to image maybe #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 86.62% 86.63%
=======================================
Files 89 89
Lines 5130 5131 +1
=======================================
+ Hits 4444 4445 +1
Misses 686 686
☔ View full report in Codecov by Sentry. |
9 tasks
| @@ -38,6 +38,9 @@ def __init__(self, viewer, array_maker): | |||
| self.viewer.figure.axes[1].scale.observe(self.debounced_update, 'min') | |||
| self.viewer.figure.axes[1].scale.observe(self.debounced_update, 'max') | |||
|
|
|||
| # Colorbar? | |||
| self.viewer.figure.axes.append(ColorAxis(scale=self.scale_image)) | |||
There was a problem hiding this comment.
Mutating python list cannot be detected, only re-assignment, so to make bqplot see this change, you should use this:
Suggested change
| self.viewer.figure.axes.append(ColorAxis(scale=self.scale_image)) | |
| self.viewer.figure.axes = [...self.viewer.figure.axes, ColorAxis(scale=self.scale_image)] |
|
Thanks! But from the discussions this morning, looks like we do not want to use ColorScale at all, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to add a colorbar for Imviz somewhere. The bqplot examples does not show that is it possible to render the colorbar separately. I tried to attach one to axes like the examples but this one does not crash but also does not show colorbar in Imviz. Need advice, @astrofrog, @maartenbreddels, or @mariobuikhuizen . 🙏