Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to add a colorbar to build on #2498. Alas, it is not as easy as when using matplotlib. Problems:
figure.axes
shows it in pop-up but I cannot figure out how to make it appear in Plot Options without popping things out. Not sure which figure axis number to adjust here.ColorAxis
span entire plot width.bqplot
examples do not dive so deeply and not obvious from API doc.plugin.viewer.selected_obj._composite_image.scale_image
as theColorScale
forColorAxis
but it does not seem to faithfully represent whatglue
is rendering in the image viewer.ColorScale
(that is actually from yet another package calledbqscales
),scheme
follows Colorbrewer names, notglue
names. So,"gray"
inglue
does nothing. I have to use"Greys"
as understood by Colorbrewer. Where is the mapping betweenglue
and Colorbrewer for this?ColorScale
,scale_type
only allows"linear"
(according tobqscales
), so the colorbar refuses to update when non-linear function is given. Forcefully settingplugin.stretch_histogram.figure.axes[2].scale.scale_type = "sqrt"
would throwTraitError: The 'scale_type' trait of a ColorScale instance expected any of ['linear'], not the str 'sqrt'.
As it currently stands, I am actually not sure if we can use this without upstream fix(es).
Refs:
Somewhat related PR(s):
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.