chore: gnoboard: Resolve ts:check errors, put in Makefile #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
…ing GRPCError Signed-off-by: Jeff Thompson <[email protected]>
…ts:check happy Signed-off-by: Jeff Thompson <[email protected]>
…e_modules. See the PR. Signed-off-by: Jeff Thompson <[email protected]>
iuricmp
approved these changes
Sep 30, 2024
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to dSocial PR gnoverse/dsocial#132, we want to use
npm run ts:checkin the Makefile for gnoboard, but first we must resolve the errors. This PR has five commits:KeyInfoinstead of the aliasGnoAccount. It seems that this was missed in one file, so we make the same change.GRPCErrorwhich expectsConnectErroror null. But the error in the catch can be any type. So add an explicit check forinstanceof ConnectError.NetworkListincludesonNetworkChange, but ChangeNetwork.stories doesn't have it. However,onNetworkChangeisn't used by the storybook, so we put a noop function.npm run ts:check. Add this as a dependency to the node_modules target, which is used by all the others.