chore: Resolve ts:check errors, put in Makefile #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <[email protected]>
…See the PR. Signed-off-by: Jeff Thompson <[email protected]>
…in imported modules Signed-off-by: Jeff Thompson <[email protected]>
…make ts:check happy Signed-off-by: Jeff Thompson <[email protected]>
… See the PR. Signed-off-by: Jeff Thompson <[email protected]>
jefft0
added a commit
to gnolang/gnonative
that referenced
this pull request
Sep 30, 2024
Similar to dSocial PR gnoverse/dsocial#132, we want to use `npm run ts:check` in the Makefile for gnoboard, but first we must resolve the errors. This PR has five commits: 1. Add ts:check to package.json 2. A [previous commit](b586114) changes gnoboard to use `KeyInfo` instead of the alias `GnoAccount` . It seems that this was missed in one file, so we make the same change. 3. In the catch clause, we call `GRPCError` which expects `ConnectError` or null. But the error in the catch can be any type. So add an explicit check for `instanceof ConnectError` . 4. The definition of `NetworkList` includes `onNetworkChange`, but ChangeNetwork.stories doesn't have it. However, `onNetworkChange` isn't used by the storybook, so we put a noop function. 5. Now that the errors are fixed, we can update the gnoboard Makefile. Add a target ts_check to do `npm run ts:check`. Add this as a dependency to the node_modules target, which is used by all the others. --------- Signed-off-by: Jeff Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use
npm run ts:checkin the Makefile, but first we must resolve the errors. This PR has five commits:process.envobject is created dynamically, so ignore errors for undefined values such asEXPO_PUBLIC_GNO_REMOTE.NetworkMetainfoandGnoAccount. Correct the import to use@gno/types.forEach((value:any, key:any).npm run ts:check. Add this as a dependency to the node_modules target, which is used by all the others.