Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[Affiliate] user is not warned about an invalid referral link #1570

Closed
elena-zh opened this issue Oct 13, 2021 · 4 comments · Fixed by #1714
Closed

[Affiliate] user is not warned about an invalid referral link #1570

elena-zh opened this issue Oct 13, 2021 · 4 comments · Fixed by #1714
Assignees
@ramirotw
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Protofire Handled by Protofire development team

Comments

@elena-zh
Copy link

Originally reported in #1405 (comment)

user is not warned about an invalid referral link:
image

Expected: validate the link to have a correct eth address as a referral
@elena-zh elena-zh added app:CowSwap CowSwap app Protofire Handled by Protofire development team Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bug Something isn't working labels Oct 13, 2021
@elena-zh elena-zh mentioned this issue Oct 13, 2021
Merged
@alfetopito alfetopito mentioned this issue Oct 13, 2021
Closed
25 tasks
@elena-zh
Copy link
Author

hey @alfetopito , I have just realized that we can have ENS names instead of wallet addresses in the referral URLs.
So, my question is: will the app be able to validate this when sharing a referral link with an ENS name in the URL?
If yes, we should include ENS name validation into the current task along with wallet address validation rules.

@alfetopito alfetopito mentioned this issue Oct 21, 2021
Open
@alfetopito
Copy link
Contributor

Great idea Elena!
I've created another task to address is #1682 and added to the Epic #1575 as good to have.
Not a blocker for release but would be a great addition

@elena-zh
Copy link
Author

Just to mention: it is not a bug related to the UI part: UI for banners will be implemented under the #1571 task, text for banner will be implemented in #1675 .
This issue is more about a link validation on its format.

@elena-zh elena-zh mentioned this issue Oct 25, 2021
Merged
@ramirotw ramirotw assigned ramirotw and unassigned maria-vslvn Oct 26, 2021
@ramirotw ramirotw mentioned this issue Oct 28, 2021
Merged
@alongoni alongoni linked a pull request Oct 28, 2021 that will close this issue
Affiliate issues #1714
Merged
@ramirotw ramirotw closed this as completed Nov 4, 2021
@ramirotw
Copy link
Contributor

ramirotw commented Nov 4, 2021

Closed by #1714

nenadV91 pushed a commit that referenced this issue Nov 15, 2021
@moodysalem
improvement: estimated amounts instead of minimum/maximums (#1570)
7a0b85b 
* estimated amounts instead of minimum/maximums

* missed a spot

* fix linting error
@anxolin anxolin mentioned this issue Apr 2, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramirotw ramirotw

Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Protofire Handled by Protofire development team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Affiliate issues gnosis/cowswap
4 participants
@alfetopito @ramirotw @maria-vslvn @elena-zh