-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
|
Related to #1512 :
|
@elena-zh all 3 issues should be fixed
|
I think it would be nice to add boarder-radius for this warning area, and make text center-aligned. |
Referral link validation works fine. @ramirotw , could you please take a look? Besides, nothing is displayed when referral part is empty. Are we OK to leave it as it is? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
Otherwise looks good.
And would love the rounded banner when inside the profile tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, however, I have created to minor related issues:
- [Affiliate] Delete an info about an invalid referral code from the localstorage #1749 [Affiliate] Delete an info about an invalid referral code from the localstorage
- [Affiliate] Remove '?referral=' from the link when a user follows a link with an empty referral code #1750 Remove '?referral=' from the link when a user follows a link with an empty referral code (very-very trivial priority)
* feat(i18n): wrapped English text around <Trans> component * cleanup * synced * regenerated locales
Summary
Fixes #1570 #1512 #1572
I grouped some small fixes into a single PR to simplify testing.