Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Affiliate issues #1714

Merged
merged 8 commits into from
Nov 2, 2021
Merged

Affiliate issues #1714

merged 8 commits into from
Nov 2, 2021

Conversation

ramirotw
Copy link
Contributor

Summary

Fixes #1570 #1512 #1572

I grouped some small fixes into a single PR to simplify testing.

@ramirotw ramirotw added the Protofire Handled by Protofire development team label Oct 28, 2021
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@elena-zh
Copy link

Related to #1512 :

  1. Great idea to display the message inside the section. As it is displayed inside, so it would be nice to remove close icon (as it is not a banner)
  2. Then, I'd rewrite the message to 'Profile page data is available for Mainnet only. Please change the network to see it.' (not a priority and might be skipped if it looks fine to everyone)
  3. Important: profile data sections are missing in the mobile view when a user is not in the Mainnet
    desktop view
    mobile view
    tablet

@ramirotw
Copy link
Contributor Author

@elena-zh all 3 issues should be fixed

  • Great idea to display the message inside the section. As it is displayed inside, so it would be nice to remove close icon (as it is not a banner)
  • Then, I'd rewrite the message to 'Profile page data is available for Mainnet only. Please change the network to see it.' (not a priority and might be skipped if it looks fine to everyone)
  • Important: profile data sections are missing in the mobile view when a user is not in the Mainnet

@elena-zh
Copy link

I think it would be nice to add boarder-radius for this warning area, and make text center-aligned.
WDYT, @alfetopito , @alongoni , @ramirotw ?
If needed, I can create a separate issue for this.

@elena-zh
Copy link

elena-zh commented Oct 28, 2021

Referral link validation works fine.
However, I have found something like a cache issue: the banner remains to be displayed when past a correct link after an incorrect one:
https://watch.screencastify.com/v/Em5kFzidR9VzSxlh8h3D

@ramirotw , could you please take a look?

Besides, nothing is displayed when referral part is empty. Are we OK to leave it as it is?
image

@alongoni
Copy link
Contributor

I think it would be nice to add boarder-radius for this warning area, and make text center-aligned. WDYT, @alfetopito , @alongoni , @ramirotw ? If needed, I can create a separate issue for this.

I'm agree! E.g.: we can add border-radius: 14px
image

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

Otherwise looks good.

And would love the rounded banner when inside the profile tab

src/custom/components/NotificationBanner/index.tsx Outdated Show resolved Hide resolved
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, however, I have created to minor related issues:

@ramirotw ramirotw merged commit a34a0d8 into release/1.4.0 Nov 2, 2021
@ramirotw ramirotw deleted the ramirotw/affiliate-issues branch November 2, 2021 11:56
nenadV91 pushed a commit that referenced this pull request Nov 15, 2021
* feat(i18n): wrapped English text around <Trans> component

* cleanup

* synced

* regenerated locales
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Protofire Handled by Protofire development team
Projects
None yet
4 participants