fix for wallet change issue #1921
Conversation
|
There was a problem hiding this comment.
Hi @nenadV91 !
The wallet is still appears disconnected when change accounts. See the video: connection is removed from the connected wallet as soon as I change a wallet. When I get back, I can see my previously connected wallet details, but I will not able to run a transaction
https://watch.screencastify.com/v/JpMBCqFM5sEhMfVvn7l3
I have also encountered a new issue: the app does not see that a wallet is disconnected after refreshing the page.
Steps:
- Connect a WC wallet
- Reload the page
- Disconnect the app inside the connected wallet
For more details please see the video: https://watch.screencastify.com/v/dZeenarRgbaOugtKacI4
|
Hmm good catch, so we are actually being disconnected from the WC when we change the wallet, so saving the data from the local storage doesn't actually make sense. |
| const tmpWCdata = localStorage.getItem(WALLET_CONNECT_STORAGE_KEY) | ||
|
|
||
| if (tmpWCdata) { | ||
| setTimeout(() => localStorage.setItem(WALLET_CONNECT_STORAGE_KEY, tmpWCdata), 1500) |
There was a problem hiding this comment.
not in love with this but it does cover the issue.
i would open an issue with them and ask about:
- a constructor param or sth allowing to set whether we want this storage wipe feature
- them to fix their listeners .on('Web3ReactUpdate') to allow us to subscribe to changes there
|
@nenadV91 what's the status with this? last comment is 11 days ago. can we close? |
|
@W3stside As we said on the sync this will not be implemented for now and I think we can close. |
|
@nenadV91 i changed the base branch to |
Summary
Fixes #1909
Fix for the issue with changing wallets and the previous connection with WalletConnect is not saved