Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[Hotfix - 1.6.1 🔥 ] - Fix for double QR code issue #1945

Closed
wants to merge 4 commits into from

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Nov 30, 2021

Summary

Fixes #1787

Fixes issues with double QR code by updating @web3-react/walletconnect-connector to new version and adding fix for some additional issues that occur after the update like missing balances and wallet info.

To test

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

* missing wallet name issue fix

* update wallet meta line
@nenadV91 nenadV91 changed the base branch from develop to master December 3, 2021 14:45
* added fix for balances not loading issue

* small updates
@nenadV91 nenadV91 marked this pull request as ready for review December 3, 2021 15:38
@W3stside
Copy link
Contributor

W3stside commented Dec 6, 2021

version name is outdated, please change this to reflect the current prod version and make sure everything is up to date. have you properly tested this?

can you provide detailed testing steps to make sure we catch any bugs and avoid what happened last time? @nenadV91

@nenadV91 nenadV91 changed the title [Hotfix - 1.5.2 🔥 ] - Fix for double QR code issue [Hotfix - 1.6.1 🔥 ] - Fix for double QR code issue Dec 6, 2021
@elena-zh
Copy link

elena-zh commented Dec 6, 2021

Hey @nenadV91 , the #1923 issue is still not fixed in this PR

@elena-zh
Copy link

elena-zh commented Dec 6, 2021

@nenadV91 , I have found an issue with MM wallet when connected with the app using WC: I can't get a signing confirmation modal in the MM. I reported an issue for the #1976

In addition, I get stuck import tokens modal when I connect to MM in XDAI using WC. The modal does not disappear until I press on the import button
stuck message

@nenadV91
Copy link
Contributor Author

nenadV91 commented Dec 9, 2021

@elena-zh
The issue with the disconnect from the wallet side should be fixed now.
Regarding MM wallet, I just tried DAI->OWL, WETH->PAX on Rinkeby and it works fine.
I did notice some issues with the MM wallet last week also so could be that, maybe try again.

@elena-zh
Copy link

Hey @nenadV91 , changes LGTM besides an issue that is not related to this PR #1987 (co I can't test changes in Mainnet)
Also, connection is lost when change wallets, but we agreed to leave it as it is #1921 (comment)

@elena-zh
Copy link

Hey @nenadV91 , the #1987 issue seems to be fixed.
However, I have noticed that it is impossible to sign an order when connected to 1Inch wallet in this PR
impossible to sign

I thought it was related to #1987, but it appeared that not. Could you please take a look into it?

Thanks

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, code-wise seems alright to me. I would give my APPROVE if you get the approve from QA

I believe you have one unaddressed comment regarding 1inch

@nenadV91
Copy link
Contributor Author

@anxolin I've posted about that in Slack https://gnosisinc.slack.com/archives/C025G521XQD/p1639403809006300, I don't have an iphone yet to debug this. I've tried browserstack but I think I need apple id to install new apps from the app store.

@W3stside
Copy link
Contributor

should we close this? @nenadV91

@anxolin
Copy link
Contributor

anxolin commented Jan 16, 2022

I thought this one was in production. can you confirm @nenadV91?

@elena-zh
Copy link

No, the issue is not in Prod. We could not release it due to 1Inch issue

@nenadV91
Copy link
Contributor Author

As Elena said this is not in Prod since there is still issue with 1inch wallet

@anxolin anxolin changed the base branch from master to develop January 20, 2022 18:11
@anxolin
Copy link
Contributor

anxolin commented Jan 20, 2022

@nenadV91, i change this into develop branch for whenever we resume it

@anxolin
Copy link
Contributor

anxolin commented Feb 28, 2022

@nenadV91 any update on this?

@nenadV91
Copy link
Contributor Author

nenadV91 commented Feb 28, 2022

@anxolin Nope, didn't work on it since we started working on claiming

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

@stale stale bot added the wontfix Stale issue label Jun 12, 2022
@stale stale bot closed this Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix Stale issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autoconnect] - wallet is not correctly connected and QR code remains
4 participants