Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[e2e] Add class and id for easy e2e #1922

Merged
merged 1 commit into from
Nov 26, 2021
Merged

[e2e] Add class and id for easy e2e #1922

merged 1 commit into from
Nov 26, 2021

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Nov 25, 2021 •
edited
Loading

Summary

Adds and ID to the "Currency List" (#currency-list) and a class name for the tokens in this list (.token-item).

This is done to make it easier to test it using 2e2 as suggested by @MareenG

image

To Test

  1. Open the token selector
  2. Review the elements have the described ID/CLASS

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@anxolin anxolin requested review from MareenG and a team November 25, 2021 15:37
MareenG
MareenG approved these changes Nov 26, 2021
View reviewed changes
Copy link

@MareenG MareenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I also tested it within the test. It works nicely.

@MareenG MareenG mentioned this pull request Nov 26, 2021
Closed
@anxolin anxolin merged commit 37518ff into develop Nov 26, 2021
@alfetopito alfetopito deleted the e2e-helpers branch November 26, 2021 16:16
@ramirotw ramirotw mentioned this pull request Dec 2, 2021
Merged
nenadV91 pushed a commit that referenced this pull request Jan 3, 2022
@JFrankfurt
replace trustwallet assets repo w/ our fork (#1922)
50c7d36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@MareenG MareenG MareenG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anxolin @alfetopito @MareenG