RC 1.6.0 #1952
RC 1.6.0 #1952
Conversation
* add shimmer effect when loading profile data * add a 5 minutes interval to profile fetch * do not reset previous profileData * Fix code style issues with Prettier * add loader to profile trades/referrals values * cancel loading when fetch fails Co-authored-by: Lint Action <[email protected]>
# Summary Fixes #1707 Remove info banner when order is recently fulfilled. # To Test 1. Navigate through a referral link with a new account. - You will see `Valid Affiliate code: You can now do your first trade to join the program` banner message 2. Under the new account do the 1st trade in the mainnet. - Information banner will disappear
* Adding errorState in useFetchProfile
# Summary Fixes #1752 Fields in sections do not have the same width. See the image:  # To Test 1. Open the page `Profile` 2. checkou items from the screenshot # Background *Optional: Give background information for changes you've made, that might be difficult to explain via comments*
…rice source (#1799) * update USD logic on block number * default to coingecko
* add zero logic for fee * None! >> Free! Co-authored-by: Leandro Boscariol <[email protected]> * add gap to popover and Free when 0 fee Co-authored-by: Leandro Boscariol <[email protected]>
* Remove ipfs-http-client and upload to ipfs using pinata sdk * Remove dep from package.json + decode the CID to get the multihash digest * Remove console.log * Update yarn.lock
Co-authored-by: Mingliang Liu <[email protected]>
# Summary Fixes #1891 #1860 Before:  After:  # To Test 1. <<Step one>> Open the page [Terms and Conditions](https://pr1894--gpswapui.review.gnosisdev.com/#/terms-and-conditions)
* Fix code style issues with Prettier * handle cancel state for ethereum txs * change type format * make Cancelled be set first instead of Confirmed Co-authored-by: Lint Action <[email protected]>
* add a new NotificationClosedUpdater to manage cross notifications close events * sync NotifactionBanner local state with global state * adds referral state sync across tabs
# Summary Closes #1750 **Proposal:** - Filtering `queryParams` when they are empty ## To test - Copy the link 'https://pr1881--gpswapui.review.gnosisdev.com/#/?referral=' - Empty URL queryParams will be removed.
* Change typo * improve sentence
* Turning on thousand separator for FIAT values * Make it also locale aware Co-authored-by: Leandro Boscariol <[email protected]>
* Added /account/<address>/orders api endpoint * Added helper function to get explorer address link * Requiring needed properties instead of concrete types on utils fns * Added addOrUpdateOrdersBatch to orders/actions * Added useAddOrUpdateOrdersBatch to orders/hooks * Added addOrUpdateOrdersBatch to orders/reducer * Added APIOrdersUpdater that checks for orders from API on connection * Adjusted displayed orders: - At most 10 regular orders and as much pending as there are - Show only connected account orders - Sort orders by creation date descending * Show only txs for connected account * Refactoring * Don't actually need a helper fn... * Added comment to make sort more explicit * Using 'Link to Explorer' instead of 'Clear activities' * Refactoring * Refactor: cache tokens loaded const * Refactor: removed duplicated css property * Refactor: removed duplicated CSS property * Refactor: extracted function transformApiOrderToStoreOrder * Refactor: renamed _orders to apiOrders * Refactor: removed duplicated CSS property * Adjusting `View all orders` link size * Added `View all orders` to the bottom of account activity * Refactored computeOrderSummary to deal with pending orders * Computing order summary for orders loaded from API * Setting isCancelling state if order is pending and cancelled on API * Actually syncing `isCancelling` flag for existing orders * Refactor: created const for magic number MAXIMUM_ORDERS_TO_DISPLAY * Refactor: simplified addOrUpdateOrdersBatch reducer * Refactor: renamed API -> Api on file name * Refactor: replaced magic number with AMOUNT_OF_ORDERS_TO_FETCH * Refactor: converted classifyLocalStatus fn to a map * Refactor: removed `Batch` from addOrUpdateOrders * Refactor: moved error exit condition up * 1334/load new tokens not yet loaded (#1504) * Added non-hook methods for dealing with contracts * New hook useTokensLazy * Exporting stuff from original codebase * Added getMultipleCallsResults under custom/state/multicall/utils Non-hook way of fetching multiple onchain queries through multicall * Refactor ApiOrdersUpdater to load tokens not yet in the UI * Typo fix * 1334/do not refetch when token added (#1536) * Removing annoying log * No longer re-fetching orders when a token is added to the list Co-authored-by: Leandro Boscariol <[email protected]> * Refactored useTokensLazy: - Added contracts cache - Improved comments * Improved doc string on multicall utils Co-authored-by: Leandro Boscariol <[email protected]> * Fix new Erc20 import path * Adjust to new multicall interface and fetchChunk changes * Adapt to renamed of ApiOrderStatus to OrderTransitionStatus * Adjusting (again) styles for `view all activity` * Handling presignaturePending state from backend * The order is concrete at this point, no need for `?.` * 1334/only update connected wallet (#1684) * Only update cancelled orders for connected wallet * Only check for unfillable orders for connected wallet * Only check pending orders for connected wallet * Always create a new state object when adding an order (#1686) Co-authored-by: Leandro Boscariol <[email protected]> * Refactor: comparing account with order.owner lowercased for safety Co-authored-by: Leandro Boscariol <[email protected]> * Added new hook useTokenLazyNoMulticall to fetch token data one by one * Using new hook to fetch tokens instead of multicall * Removed multicall/utils * Removed useTokensLazy hook * Renamed file useTokensLazy to useTokenLazy * Renamed useTokenLazyNoMulticall to useTokenLazy * Removed unused import * Updated debug log messages * Small refactor in #1639 (#1857) * Only init bytes32Contract if we really need to * Fixing build error: only proceed if library is set Co-authored-by: Leandro Boscariol <[email protected]> * 1334/with swr (#1906) * Refactor: removed unnecessary variable * Added SWR as dev dependency * Added hook useApiOrders using useSWR hook * Using new hook for fetching api orders * Removed unused imports... Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Anxo Rodriguez <[email protected]>
|
|
Hey @ramirotw , @alfetopito , should we include into the RC #1639 pr? Thanks |
|
Hey @ramirotw , I can't get 'Cancelling' state for transactions in this PR (#1532 ) for the Mainnet and xDAI transactions. See the video: https://watch.screencastify.com/v/IefumKIH4F3heceqAEw1 The same is for the Wrap and Unwrap transactions. In Rinkeby it works. with issues: #1832 I think, we could also postpone releasing this PR until #1832 is fixed along with the issue about cancelling state in the Mainnet/XDAI #1954. |
Good call, not sure, @alfetopito created the |
Anyways, it works as expected: orders are synced and loaded from API. |
Co-authored-by: Leandro Boscariol <[email protected]>
@elena-zh is the Speed up (and transaction replacement) working? just to be sure the blocknative integration works for mainnet |
|
@ramirotw , seems that no, but I'm not sure. See the video: |
did the Speed up transaction get mined? |
|
Elena, without any deep investigation, I suspect this could be due to the race condition in case the original tx gets mined before the speed-up tx. If so, it'll be addressed on that task. |
Finally, yes. https://etherscan.io/tx/0x6a7028a6a2447483b5d8700024beb42c3b77c6f2c26ded0eb54e8fc644fe135e Btw, approve transaction from the 1st video was also mined in an hour or two. It was not cancelled, however, I tried it several times in my MM wallet. https://etherscan.io/tx/0xd96f9e333278e8d64e562259c55e27e7593a3253c1ef2f7423a3f117a07daa75 |
Summary
This minor release added small improvements to existing features as well as some refactors.
Changelog
320cd47 Enable 1inch (#1942)
2fc6c81 1334/activity orders from api rebased (#1639)
8663505 Turning on thousand separator for FIAT values (#1934)
e97277f Change typo (#1926)
c015168 Version images to prevent hard caches (#1925)
37518ff Add class and id for easy e2e (#1922)
de6e1fa Increase update time for orders (#1893)
443a98f Filter emtpy queryParams (#1881)
443ecf0 [Affiliate] Update banner closed state across tabs (#1875)
02fd6cb Handle cancel state for ethereum txs (#1532)
8573162 (bugfix) Terms and conditions styles (#1894)
28f8173 bold numbers in T&C page (#1860)
738006c [Profile] Add name to IPFS files + Upload JSON using pinata (#1865)
3a67534 Fix image link in README (#1838)