Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Pr 1639 follow up #1951

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Pr 1639 follow up #1951

merged 3 commits into from
Dec 2, 2021

Conversation

alfetopito
Copy link
Contributor

Summary

Follow up to PR #1639

  • Refactoring
  • Re-fetching orders list every 30s

To Test

  1. Connect the same account in 2 different browsers/devices
  2. Place order in one of them
  • After up to 30s, the other browser should load the order from the first

@alfetopito alfetopito self-assigned this Dec 1, 2021
@alfetopito alfetopito requested review from a team December 1, 2021 20:59
@alfetopito alfetopito mentioned this pull request Dec 1, 2021
Merged
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@elena-zh elena-zh mentioned this pull request Dec 2, 2021
Merged
elena-zh
elena-zh approved these changes Dec 2, 2021
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I got synced transactions at 3 devices at a time!
Still, transactions are not synced, but this is a not part of the current PR.

anxolin
anxolin approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

I love all the changes of names, and the new optional param for the hook.

@alfetopito alfetopito merged commit 9ea601f into develop Dec 2, 2021
@alfetopito alfetopito deleted the pr-1639-follow-up branch December 2, 2021 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfetopito @anxolin @elena-zh