Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Fix explorer link #2263

Closed
wants to merge 2 commits into from
Closed

Fix explorer link #2263

wants to merge 2 commits into from

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jan 23, 2022

Summary

Fix the Explorer link URL. It was wrong for Gnosis Chain. Also addresses the suggestion from @elena-zh to make it more

Before:
image

And will always take you

After:
image

And:

  • Takes you to the right explorer depending on the network
  • The label would be more precise, i.e. "Verify on Blockscout" if network is Gnosis Chain

To Test

  1. Do a claiming in the 3 networks. You can use the first two tabs of this file to find dummy examples: https://docs.google.com/spreadsheets/d/1pf97wtawkibZPNTrVbyo2FSZKXf6Xo_A0sddWXKxnE4/edit#gid=1980526507
  2. Verify the link, should say "Verify on Etherscan" or "Verify on Blockscout" and take u to the right place

@anxolin anxolin requested review from a team January 23, 2022 11:41
@anxolin anxolin marked this pull request as ready for review January 23, 2022 11:42
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@anxolin
Copy link
Contributor Author

anxolin commented Jan 24, 2022

I will close this one in favour of this other one #2277

@anxolin anxolin closed this Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants