Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Fix Gnosis Safe claiming Workflow #2277

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Fix Gnosis Safe claiming Workflow #2277

merged 2 commits into from
Jan 24, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jan 24, 2022

Summary

This PR address the issue with the broken link for Gnosis Safe transactions. Close #2270

Now it shows the right link that takes you to Gnosis Safe, so you can sign the tx there:
Screenshot at Jan 24 15-10-12

The link will take you to the queue:
Screenshot at Jan 24 15-11-03

The transaction is also visible in the recent activity window:
Screenshot at Jan 24 15-12-51

To Test

  1. Claim something using Gnosis Safe
  2. Make sure link works
  3. Do the same with an EOA, make sure it still works

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@anxolin anxolin changed the title Fix link safe Fix Gnosis Safe claiming Workflow Jan 24, 2022
@anxolin anxolin marked this pull request as ready for review January 24, 2022 15:16
@elena-zh
Copy link

Hey @anxolin , seems the issue is not fixed:
image
View on Etherscan link navigates to the 404 page in Rinkeby:
https://watch.screencastify.com/v/t0xmkD0yeAmcdPqe902V

@anxolin anxolin requested review from a team January 24, 2022 16:29
@nenadV91
Copy link
Contributor

I'm seeing this with gnosis-safe
Screenshot from 2022-01-24 17-43-14

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now!

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

Also great feature on the Safe side where you can clearly see all the parameters and stuff
Screen Shot 2022-01-24 at 10 43 08

@anxolin
Copy link
Contributor Author

anxolin commented Jan 24, 2022

Works now!

I promise i didn't change anything. It was GH not deploying. Thanks for testing again :)

@anxolin anxolin merged commit b7f82f0 into develop Jan 24, 2022
@alfetopito alfetopito deleted the fix-link-safe branch January 25, 2022 00:16
@W3stside
Copy link
Contributor

Approved

@anxolin anxolin restored the fix-link-safe branch February 25, 2022 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigate to Gnosis safe when Claim transaction is signing
5 participants