This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Update review text based on chainId #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anxolin
approved these changes
Feb 2, 2022
| @@ -56,11 +57,12 @@ const STEPS_DATA = [ | |||
| }, | |||
| ] | |||
|
|
|||
| const FAQ_DATA = [ | |||
| const FAQ_DATA = (chainId: number | undefined) => [ | |||
There was a problem hiding this comment.
nit: why not passing directly the string? seems cleaner logic
There was a problem hiding this comment.
I think this is more flexible just in case there are some other changes in text based on chainId in the future.
nenadV91
added a commit
that referenced
this pull request
Feb 3, 2022
ramirotw
pushed a commit
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2370
As described in the issue this will remove Ethereum word from the FAQ on the xDai.