This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[RELEASE 🪄 ] v1.11.0-RC.0 #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unused audio. * Rename and remove .asd file
Co-authored-by: Leandro <[email protected]>
* Add CLA * Fix code style issues with Prettier Co-authored-by: Lint Action <[email protected]>
* Improve responsiveness of header elements. * Fix breakpoints. * Reset max-width
Bumps [simple-get](https://github.com/feross/simple-get) from 2.8.1 to 2.8.2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/feross/simple-get/commit/4e156b6bb19e11ccfad05fad310ea799d63f890d"><code>4e156b6</code></a> 2.8.2</li> <li><a href="https://github.com/feross/simple-get/commit/43c272db3e4b1383cb03d80338dba3e08c451641"><code>43c272d</code></a> Bug fix: Thirdparty cookie leak</li> <li>See full diff in <a href="https://github.com/feross/simple-get/compare/v2.8.1...v2.8.2">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~linusu">linusu</a>, a new releaser for simple-get since your current version.</p> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/gnosis/cowswap/network/alerts). </details>
* Using hardcoded gas values for gchain * Using Blockscout's gas oracle on gchain instead of hardcoded values * Adding 20% extra margin for gas estimation * Sorting the imports a little bit Co-authored-by: Leandro <[email protected]>
* Fix readme path and add users * Add missing people
# Summary Fixes #2149  # To Test 1. Open the [...] Menu and see the "View all order" link position. (this link appears to a connected user who has done a trade in the platform.) # Extra: - External link arrow added on activity modal:  - Icon style (Before -> After):  
* Show banner if the user has claimed already * Update claimed banner message and color * Change one const name
* Updated state to store count of classified claims other than a boolean * Updated the updater to store the count of classified claims * Updated claims on other network banner to check according to claim counts * Fixed issues with claim on multiple networks - Updated state to add new dimension to claim info: account Otherwise when checking a different account the state would be preserved and would lead to bad data - Refactored Updater to fix dependency on obj causing it to being stuck in a re-render loop - Fixed logic that compared different types using `===` instead of `==` - Fixed logic that was causing claim to be displayed when there were no claims * Refactoring variable Co-authored-by: Leandro <[email protected]>
* mod switch/addNetworks util * fix chain info object
# Summary Fixes #2409 - [x] Remove 'already traded' message. - [x] Enhance all the rest messages. # To Test 1. Open the page `Profile`
# Summary Fixes #1145 **Confirmation Modal:**  **Select a token modal:** Before/After <img src="https://user-images.githubusercontent.com/622217/154315857-70536655-2718-4cee-a41b-201d7bd12549.png" width="50%"><img src="https://user-images.githubusercontent.com/622217/154315740-d58a968b-bbe4-4247-86fb-abc42a21bb99.png" width="50%"> **Styles on main scrollbar:** Before:  After:  # To Test
# Summary Fixes #2150  # To Test 1- Open [T&C page](https://pr2483--gpswapui.review.gnosisdev.com/#/terms-and-conditions). Go to 16.1. section and check the gnosis forum link. It should be opened in a new tab.
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
their file name changed as seen here: opynfinance/opyn-tokenlist@409fdc8
* Fix for cancel claim issue * Update rinkeby address and claim repo * Revert "Update rinkeby address and claim repo" This reverts commit d902e5f.
* Using latest contract and deployment info for rinkeby * Fix for already claimed button on claim successful screen * Revert "Merge branch 'valid-rinkeby-claims-on-master' into 2416/already-claimed-button-fix" This reverts commit c84734c, reversing changes made to a6a8995. Co-authored-by: Leandro <[email protected]>
# Summary Fixes #1276 and #1550 The layout has changed a bit. Some small resolutions now have less padding on top but the scroll not appear. Before (on production with scroll):   After (on this PR without scroll):   # To Test 1. <<Step one>> Open the page [`Swap`](https://pr2488--gpswapui.review.gnosisdev.com/)
* Using latest contract and deployment info for rinkeby * Fix for claim cancel popup icon * Revert "Merge branch 'valid-rinkeby-claims-on-master' into 2490/popup-icon-issue" This reverts commit 4cdc146, reversing changes made to 3a7d0ad. Co-authored-by: Leandro <[email protected]>
* Add fast price fetching * Add best quote loader * Loader style update * Change quote loader to old cow loader * Fix for potential race condition issue * PR updates
This reverts commit 67d6294.
|
* testing * Enable Coinbase Wallet (wallet-link) (#2353) * enable walletlink and upgrade package * Limiting the supported networks for CoinbaseWallet * Adding setDefaultInjected provider * Enable Formatic wallet (#2388) * Activate formatic wallet * Adding reconnect Uninjected Provider * Adding connecting web3Status after refresh * Upgrade fortmatic to v2.2.1 * Mute unnecessary Overlay useEffect * Adding new API 🔑 * Adding custom src/custom/connectors/Fortmaitc.ts * merger conflict resolution * set api key according to environment (#2422) * Change clickable, fortmatic supportedChains, enum DefaultInjected * Change CW deeplink * Testing walletLink on mobile (cherry picked from commit e88eb5e)
|
I have retested newly added wallets and have no encountered new issues besides these low priority known ones:
|
anxolin
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
I would merge this to master, it's best to test it there the RCs.
I would think, nothing here is bad that it goes to Barn.
Also, @elena-zh some 2 imp things that change here would be good to test:
- affiliate: we changed the pinata integration, we just need to make sure is not broken. Also theres the change of removing annoying messages
- faster price response: now we have the 2 price queries (fast and slow). The fast one gives a quick price to the user, the slow one, updates the price later if some better price was found
|
@biocom Question about this release, if we have the price, as it seems the case, shouldn't we do at least the shimmer effect? Maybe the idea of showing all the liquidity providers doesn't need to be here, but probably good to try to round a bit the feature, right? |
@anxolin , sure. I will retest it in Staging as well. |
* adding latest errors and update comment urls * standardise format of error descriptions * add GpQuoteErrorDetails mapping * add transfer-eth-to-smart-contract error * standardise quoteerror description * text correction Co-authored-by: Anxo Rodriguez <[email protected]> Co-authored-by: Anxo Rodriguez <[email protected]>
|
i would consider adding #2518 as it will add, to prod, better sentry reporting (marginally better, but still) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
f4e511f [2506] Sync BE errors with FE (#2507)
ffbbda9 Use previously supported wallets (#2166)
670ecf3 Revert "Swap page layout (#2488)"
588ccf2 Add fast price fetching (#2477)
90e6843 Reduce dependencies (#2480)
795f7fc Fix for claim cancel popup icon (#2501)
67d6294 Swap page layout (#2488)
6be36ca Fix for already claimed button on claim successful screen (#2478)
af28821 2473/cancel claim issue (#2485)
55ffce3 Fix 404 for OPYN_LIST url (their file name changed) (#2481)
32c4765 Bump url-parse from 1.5.3 to 1.5.7 (#2476)
a8157ce 2150 Terms and Conditions: gnosis forum link (#2483)
6dc3d57 Scrollbar styles (#2421)
e4364cb Fix avilable claims issue on rinkeby (#2420)
7319d6c Enhance messages for Affiliate program (#2414)
e28bfd3 1867 - Add network if nonexistent (#2424)
9189731 2382/already claimed (#2394)
451206f Removed Ethereum word from popup text msg (#2412)
a57279f Show banner if the user has claimed already (#2393)
1e1b409 Menu: view all orders position (#2399)
ad5e98c Fix readme path and add users (#2400)
b551f2b Merge branch 'hotfix/1.10.1' into develop
af1a7c6 Updated gas estimation for gchain (#2391)
6763fc2 Bump simple-get from 2.8.1 to 2.8.2 (#2392)
ee0101a Improve responsiveness of header elements. (#2376)
653d9b6 Add alternative claim success sound. (#2384)
94245c5 Fix token display in dark/light mode for transactions. (#2386)
c939d78 Add CLA (#2390)
d1119ca Fix e2e (#2379)
e7feb5d Moved claim state updater to claim page (#2380)
22fc2d1 Update confirmation text based on chainId (#2373)
505a3b4 Remove some claim functions that are not being used (#2372)
fcb05fe Fix claim input error message position (#2368)
913a30a remove unused audio. (#2348)