Adding S3 support for HTTP domain validation #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
area/httpprovider
state/need-user-tests
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ldez
force-pushed
the
feature/s3-as-http-provider
branch
from
f130bd6
to
aac8250
Compare
ldez
force-pushed
the
feature/s3-as-http-provider
branch
from
aac8250
to
a6d00c4
Compare
ldez
force-pushed
the
feature/s3-as-http-provider
branch
from
9bc50f7
to
812b941
Compare
|
I follow your PR and migrate route53 and lightsail to the SDK v2: #1973 |
|
I will ask you to provide a command example and the output of this command. (with redacted information 😉) |
|
@beornf could you try this PR? |
$ ./dist/lego -k rsa2048 --domains "<redacted>" --server https://emea.acme.atlas.globalsign.com/directory --kid <redacted> --eab --hmac <redacted> --http.s3-bucket daveacmetest --http --email <redacted> run
2023/07/25 13:04:34 [INFO] [<redacted>] acme: Obtaining bundled SAN certificate
2023/07/25 13:04:35 [INFO] [<redacted>] AuthURL: https://emea.acme.atlas.globalsign.com/authz/<redacted>
2023/07/25 13:04:35 [INFO] [<redacted>] acme: use http-01 solver
2023/07/25 13:04:35 [INFO] [<redacted>] acme: Trying to solve HTTP-01
2023/07/25 13:04:41 [INFO] [<redacted>] The server validated our request
2023/07/25 13:04:41 [INFO] [<redacted>] acme: Validations succeeded; requesting certificates
2023/07/25 13:04:42 [INFO] Wait for certificate [timeout: 30s, interval: 500ms]
2023/07/25 13:04:42 [INFO] [<redacted>] Server responded with a certificate. |
beornf
suggested changes
Jul 25, 2023
beornf
reviewed
Jul 26, 2023
|
can you add a small readme inside the package to explain how to set it up (permissions, expectations, ...)? |
ldez
force-pushed
the
feature/s3-as-http-provider
branch
from
7ba6811
to
a21d29d
Compare
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to allow upload token to S3 for HTTP domain Validation
Fixes #1969
Closes #334