Add missing return to handleSettingRemoteAddrError (#16794) (#16795)

Backport #16794 There is a missing return in handleSettingRemoteAddrError which means that the error page for repo settings is duplicately rendered. Fix #16771 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
go-gitea · Aug 23, 2021 · 31e4e82 · 31e4e82
1 parent 37e4cdb
commit 31e4e82
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/routers/web/repo/setting.go b/routers/web/repo/setting.go
@@ -742,6 +742,7 @@ func handleSettingRemoteAddrError(ctx *context.Context, err error, form *forms.R
 		default:
 			ctx.ServerError("Unknown error", err)
 		}
+		return
 	}
 	ctx.RenderWithErr(ctx.Tr("repo.mirror_address_url_invalid"), tplSettingsOptions, form)
 }